From: Valters Jansons <valter.jansons@gmail.com>
To: location@lists.ipfire.org
Subject: [PATCH] systemd: Standartize on Wants=/After= for network
Date: Thu, 29 Oct 2026 21:11:34 +0900 [thread overview]
Message-ID: <20261029121134.93697-1-valter.jansons@gmail.com> (raw)
Current Requires=network.target is very strict. Standard practice is to
set it as Wants= instead as a lighter "should". The application can
then see what is actually going on.
Furthermore, an After= should be in place so that Systemd properly stops
the updater prior to bringing the network stack offline.
Signed-off-by: Valters Jansons <valter.jansons@gmail.com>
---
src/systemd/location-update.service.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/systemd/location-update.service.in b/src/systemd/location-update.service.in
index 50ba01f..b491a12 100644
--- a/src/systemd/location-update.service.in
+++ b/src/systemd/location-update.service.in
@@ -1,7 +1,8 @@
[Unit]
Description=Automatic Location Database Updater
Documentation=man:location(1) https://man-pages.ipfire.org/libloc/location.html
-Requires=network.target
+Wants=network.target
+After=network-online.target
[Service]
Type=oneshot
--
2.56.0
next reply other threads:[~2026-10-29 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 12:11 Valters Jansons [this message]
2026-10-29 15:49 ` Michael Tremer
2026-10-29 16:19 ` [PATCH v2] systemd: Depend on network using Wants=/After= Valters Jansons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029121134.93697-1-valter.jansons@gmail.com \
--to=valter.jansons@gmail.com \
--cc=location@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox