public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Valters Jansons <valter.jansons@gmail.com>
To: Michael Tremer <michael.tremer@ipfire.org>
Cc: location@lists.ipfire.org, Stefan Schantl <stefan.schantl@ipfire.org>
Subject: [PATCH v2] systemd: Depend on network using Wants=/After=
Date: Fri, 30 Oct 2026 01:19:27 +0900	[thread overview]
Message-ID: <20261029161927.22896-1-valter.jansons@gmail.com> (raw)
In-Reply-To: <328A7BD5-1C4F-43E2-941D-D351ED2587AC@ipfire.org>

Wants= is the recommended way to hook the start-up of one unit to the
start-up of another unit. We do not directly benefit from the stricter
Requires=.

Furthermore, we should be explicit and define an After= instead of
assuming the default dependencies ordering will be added.

Signed-off-by: Valters Jansons <valter.jansons@gmail.com>
---
Michael, thank you for the investigation.
Resubmitting the systemd change as suggested.

 src/systemd/location-update.service.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/systemd/location-update.service.in b/src/systemd/location-update.service.in
index 50ba01f..e1b8b39 100644
--- a/src/systemd/location-update.service.in
+++ b/src/systemd/location-update.service.in
@@ -1,7 +1,8 @@
 [Unit]
 Description=Automatic Location Database Updater
 Documentation=man:location(1) https://man-pages.ipfire.org/libloc/location.html
-Requires=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=oneshot
-- 
2.56.0



      reply	other threads:[~2026-10-29 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 12:11 [PATCH] systemd: Standartize on Wants=/After= for network Valters Jansons
2026-10-29 15:49 ` Michael Tremer
2026-10-29 16:19   ` Valters Jansons [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029161927.22896-1-valter.jansons@gmail.com \
    --to=valter.jansons@gmail.com \
    --cc=location@lists.ipfire.org \
    --cc=michael.tremer@ipfire.org \
    --cc=stefan.schantl@ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox