public inbox for location@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: location@lists.ipfire.org
Cc: Valters Jansons <valter.jansons@gmail.com>
Subject: Re: [PATCH] tests: Avoid printing the entire test database
Date: Tue, 27 Oct 2026 10:59:27 +0000 (UTC)	[thread overview]
Message-ID: <4jDSDb684dzTj3N@michael.haj.ipfire.org> (raw)
In-Reply-To: <20261026201637.574025-1-valter.jansons@gmail.com>

Hello Valters,

Thank you very much for the patch. That output was indeed useful when
the Lua bindings were written, but it has been of no use for a long
time and it made the build logs a lot larger than they needed to be. The
log of the Lua test is about 200 times shorter now, and the test still
passes.

I have merged it:

  https://git.ipfire.org/?p=location/libloc.git;a=commit;h=960f2a4

One small thing for next time: please add a "Signed-off-by:" line to
your patches (git commit -s), as described here:

  https://wiki.ipfire.org/devel/submit-patches

It is not a problem this time, but we cannot merge patches without it
later on.

Best,
-Michael


      reply	other threads:[~2026-10-27 10:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 20:16 Valters Jansons
2026-10-27 10:59 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4jDSDb684dzTj3N@michael.haj.ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=location@lists.ipfire.org \
    --cc=valter.jansons@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox