[PATCH] tests: Avoid printing the entire test database

[PATCH] tests: Avoid printing the entire test database

[Valters Jansons]

Lua tests currently iterate the database, and dump all of its contents
into the runner's log. This might be beneficial in testing, however it
does not necessarily help during regular builds.

This commit retains the reverse_pointer() invocation, but instead of
printing simply counts the number of entries and asserts at at least
something existed.
---
 tests/lua/main.lua.in | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/lua/main.lua.in b/tests/lua/main.lua.in
index c947334..290e832 100755
--- a/tests/lua/main.lua.in
+++ b/tests/lua/main.lua.in
@@ -219,9 +219,14 @@ function test_list_networks()
 	db = location.Database.open(ENV_TEST_DATABASE)
 	luaunit.assertNotNil(db)
 
+	local count = 0
+
 	for network in db:list_networks() do
-		print(network, network:reverse_pointer())
+		network:reverse_pointer()
+		count = count + 1
 	end
+
+	luaunit.assertTrue(count > 0)
 end
 
 os.exit(luaunit.LuaUnit.run())
-- 
2.56.0

Re: [PATCH] tests: Avoid printing the entire test database

[Michael Tremer]

Hello Valters,

Thank you very much for the patch. That output was indeed useful when
the Lua bindings were written, but it has been of no use for a long
time and it made the build logs a lot larger than they needed to be. The
log of the Lua test is about 200 times shorter now, and the test still
passes.

I have merged it:

  https://git.ipfire.org/?p=location/libloc.git;a=commit;h=960f2a4

One small thing for next time: please add a "Signed-off-by:" line to
your patches (git commit -s), as described here:

  https://wiki.ipfire.org/devel/submit-patches

It is not a problem this time, but we cannot merge patches without it
later on.

Best,
-Michael