From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ovpnmain.cgi: Show only IP for Real Address in Connection Statistics page
Date: Thu, 29 Jan 2026 20:06:26 +0100 [thread overview]
Message-ID: <2c0a0241-8a4a-43a7-833c-6cf4f7b87c3c@ipfire.org> (raw)
In-Reply-To: <20251106125225.85685-1-adolf.belka@ipfire.org>
Hi Michael,
I realised that my patch below had not been dealt with. Was it just missed? If it is okay, do I need to resubmit the patch with the time period that has gone past?
Regards,
Adolf.
On 06/11/2025 13:52, Adolf Belka wrote:
> - IP:Port was being shown rather than IP alone. The status was being split but not copied
> back into the variable that is then shown on the status page.
> - Tested on my vm system. The status page changed from showing IP:Port to only IP for
> Real Address.
>
> Tested-by: Adolf Belka <adolf.belka@ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index ec86a218b..814499d21 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2,7 +2,7 @@
> ###############################################################################
> # #
> # IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2023 IPFire Team <info@ipfire.org> #
> +# Copyright (C) 2007-2025 IPFire Team <info@ipfire.org> #
> # #
> # This program is free software: you can redistribute it and/or modify #
> # it under the terms of the GNU General Public License as published by #
> @@ -3178,6 +3178,7 @@ END
> $users[$uid]{'Since'} = $match[5];
>
> my $address = (split ':', $users[$uid]{'RealAddress'})[0];
> + $users[$uid]{'RealAddress'} = $address;
> $users[$uid]{'Country'} = &Location::Functions::lookup_country_code($address);
> $uid++;
>
prev parent reply other threads:[~2026-01-29 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 12:52 Adolf Belka
2026-01-29 19:06 ` Adolf Belka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0a0241-8a4a-43a7-833c-6cf4f7b87c3c@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox