Development February 2014

development@lists.ipfire.org

4 participants
6 discussions

DynDNS support for ddns project.
by Stefan Schantl 16 Jun '14

16 Jun '14

Hello guys, i've created a patch for the Dynamic DNS client for IPFire. (http://git.ipfire.org/?p=oddments/ddns.git;a=summary) My patch will add support for the very popular "dyndns.org" provider. However I wasn't able to test my changes, because I don't have any account there and I seems new members have to purchase to use use it. So, I need your help to test my changes and finally be able to support that provider in the next major version of IPFire. Best regards, Stefan

2 3

Toolchain Build Failure
by Sascha Kilian 26 Feb '14

26 Feb '14

Good Morning, i tried to make a clean build to verify the Fireinfo and have the newest version. i can reproduce this by run the following commands: on ipfire-2.x folder "git checkout next" (told me i am already on this) "git pull" (told me some updates or up-to-date) "./make.sh clean" "./make.sh build" on Building the Toolchain::ncurses i got following Compile error make[2]: Leaving directory `/opt/ipfire/ipfire-2.x/build/usr/src/ncurses-5.9/widec/c++' make[1]: Leaving directory `/opt/ipfire/ipfire-2.x/build/usr/src/ncurses-5.9/widec' # Install everything. cd /opt/ipfire/ipfire-2.x/build/usr/src/ncurses-5.9 && make -C narrowc install.{libs,progs,data} make[1]: Entering directory `/opt/ipfire/ipfire-2.x/build/usr/src/ncurses-5.9/narrowc' make[1]: *** No rule to make target `install.{libs,progs,data}'. Stop. make[1]: Leaving directory `/opt/ipfire/ipfire-2.x/build/usr/src/ncurses-5.9/narrowc' make: *** [/opt/ipfire/ipfire-2.x/log/ncurses-5.9-tools] Error 2

2 4

fireinfo Bug for Kernel Informations and Root Disk Size
by Sascha Kilian 24 Feb '14

24 Feb '14

Hi there, it is my first post on this list. If i make some misstakes, please tell me. If trying to figure out why the Diskspace is not shown in my Profile. i figured out that some bugs in fireinfo "system.py" exist. in line 450 "print s.kernel" -> "s.kernel_release" The root_size is null, i have patched some in the system.py and make the path in line 388 Static to "/sys/block/sda/size" then he got the right size. I think it needs to be other identification, sda is the MBR not the right partition (sda3). My Python expirience is too low to make this right. Best regards from Germany Sascha Kilian

2 5

Feedback wanted on feature to show blocked IPs per country
by Alf Høgemark 17 Feb '14

17 Feb '14

Hi Based on the existing firewalllogip.dat and firewalllogport.dat, I want a similair function to show which countries gets blocked, to see which country is mainly targeting my servers. I've made a preliminary prototype, you can see it here : https://github.com/alfh/ipfire-2.x/commit/a99ee9ce4fcdc9e41bfdfd7bd169324d1… This works on my existing 2.13 Core75. There is no right menu, it is just a preliminary prototype as of now. What I basically have done, is to copy firewalllogip.dat and showrequestfromip.dat, and modified them so they work on "country for ip address" rather than inidividual ip address. This raises a few questions in my mind : 1. Code duplication. By just copying the firewalllogip.dat, I duplicate a lot of code. To me, this also seems to be the case already, where firewalllogip.dat and firewalllogport.dat containing a lot of duplicated code. Any ideas how to avoid this ? Has it been discussed to try to minimze the existing code duplication in the cgi-bin files ? 2. Do think "local ip addresses" should turn up in firewalllogcounty.dat ? Here is the main part of my code : my $gi = Geo::IP::PurePerl->new(); .... if($_ =~ /SRC\=([\d\.]+)/){ my $srcaddr=$1; my $ccode = $gi->country_code_by_name($srcaddr); my $fcode; # TODO: should local IP adresses be include as unknown, or excluded from the statistics totally ? # TODO: it would be nice to be able to group local IPs into "red", "green", "blue" etc if( $ccode eq "") { $ccode = "unknown"; } else { $tabjc{$ccode} = $tabjc{$ccode} + 1 ; if(($tabjc{$ccode} == 1) && ($lines < $pienumber)) { $lines = $lines + 1; } $linesjc++; } } As you can see, I now decide to not include the local ip addresses. I also currently do not differentiate between local ip addresses and ip addresses where country code is actually unknown. I'll have to check if Geo::IP has some functionality to tell me if the address is part of "non routable addresses", like 192.168.x.y. 3. Is there functionality existing in ipfire cgi-bin code to check if an ip address is part of the netmask of the "green", "red", "blue", "yellow" interface ? If so, I think I would like to treat them like "countries". 4. Do other people find this functionality useful ? Regards Alf

3 4

What is the process for suggesting bug fixes and improvements (bugtracker vs gitbug) ?
by Alf Høgemark 17 Feb '14

17 Feb '14

Hi I started to use Ipfire 2.13 core 75 last week, and I have found a few bugs and some areas for improvements. I have made 3 pull requests on github, https://github.com/ipfire/ipfire-2.x/pulls, from my github https://github.com/alfh/ipfire-2.x. What process do you prefer for people suggesting bug fixes and minor improvements ? Should I make an issue in the bug tracker for each of my pull requests ? Should I rather attach a patch to a bug tracker issue than issuing pull requests on github ? I guess improvements I should raise on this mailing list, to see if other people agree on the improvement ? I have made a bug fix and an improvements to updxlrator, a fix to netexternal.cgi and started an improvement on firewalllog.dat. I also have just started playing with another improvement, to list the number of firewall log entries per country, to be able to see where blocked machines are coming from. Is this something you think would be useful ? Regards Alf Høgemark

3 7

Using xhtml strict or html5 for the web gui ?
by Alf Høgemark 12 Feb '14

12 Feb '14

Hi I was trying to validate the html pages of the web GUI of Ipfire. Although having pages that passes a validator is not absolutely requried, I think it makes styling easier, and it makes good sense to make sure table cells and rows are properly closed etc etc. It is a kind of indicator of code quality. I then noticed that the ipfire web GUI is using the doctype for xhtml strict. But the actual html itself seems to be a bit old style, with lots of align, valign attributes on tags, which will not validate as xhtml, even if all the tags are properly closed. Have you considered going for "html5" doctype ? Using html5, I think it would require a lot less cleanup to make the pages validate. And when a page validates, it makes it easier to test the page using a validator after you make code changes, to make sure it still validates. Regards Alf Høgemark

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Development February 2014