Hi Michael,
Yes, some of the problems have been fixed.
On 06/08/2024 17:52, Michael Tremer wrote:
Hello,
I just pushed a bunch of changes that should hopefully resolve a few of the problems.
The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
Please give the recent changes a test and let me know how it works.
I made sure that I did a browser cache clear before reviewing the changes.
The core programs section of the Services page now has colour on it for the status of running or stopped.
The colours are not there for the status of any of the addons.
The Processes and Processes memory graphs that are normally on that page are now completely missing.
Screenshot attached.
The colour for the status is not showing for the IPSec and OpenVPN client connections.
Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
Regards,
Adolf.
-Michael
On 3 Aug 2024, at 11:48, Adolf Belka adolf.belka@ipfire.org wrote:
Hi Michael,
On 02/08/2024 11:12, Michael Tremer wrote:
Hello Adolf, Thank you for looking at this in depth :)
On 1 Aug 2024, at 16:01, Adolf Belka adolf.belka@ipfire.org wrote:
Hi Michael,
Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
That is good news!
In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more. This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab8... If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
Yes, I found that the browser cache was affecting things. However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet. Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
So it is correct that the outer box is gone. The graph only has a headline when it needs one. The Hour/Day/Week/… controls should however remain the same.
That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
This is probably a bug from my changes in the tooling.
I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
I don't know what is going on here.
Me pushing a lot of changes at a fast pace :)
:-)
Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
That looks good.
All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
Okay, this would be something that needs fixing then.
Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
On the Services page the first graph which should be titled Processes is labelled 100%.
On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
The following menu items showed longer entry boxes that overlap labels or other elements DHCP DNS Forward Static Routes Wake on LAN Time Server Log Settings Proxy Logs
The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example Firewall Groups Firewall Options Blue Access Log Summary Dynamic DNS Proxy reports Firewall logs Firewall graphs - IP, Port & Country IPS Logs IP Address blocklist logs OpenVPN RW logs URL Filter Logs System Logs Captive portal Connection Scheduler Assign MAC Address
The following menu items showed no change/issues except maybe for the graph period selection buttons . Backup Shutdown Credits Mailservice Memory Media Network External, Internal and Other OpenVPN RW and N2N Statistics WIO Hardware graphs Connections Mdstat DNS Web Proxy URL Filter Update Accelerator Edit Hosts QOS IP Address Blocklist Location Block IPTables
I am really sorry for giving false hope that the cleanup branch had gone really well.
Well, it happens :) That is why next is called next.
Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
Regards, Adolf.
-Michael
Regards,
Adolf.
On 01/08/2024 12:50, Adolf Belka wrote:
Hi Michael,
On 25/07/2024 12:28, Adolf Belka wrote:
Hi Michael,
On 25/07/2024 10:44, Michael Tremer wrote: > Hello Adolf, > > Thank you for getting back on this so quickly. >
Maybe I got back too quickly!!
I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
Downloading the iso today from the latest directory gives me the build ed2c97b7.
I am going to install that version now but I suspect it will show the same as I found with my build.
So it looks like my original review was based on the version before the cleanup branch changes were included.
I will come back with new feedback of what I find from the latest branch that I have now downloaded.
Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
Regards,
Adolf
> I suppose this also means that the ISO in the next branch boots just fine, too?
Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all. This tested out raid and all 4 interfaces.
Regards, Adolf.
> > Best, > -Michael > >> On 25 Jul 2024, at 09:07, Adolf Belka adolf.belka@ipfire.org wrote: >> >> Hi Michael, >> >> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine. >> >> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems. >> >> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ... >> >> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me. >> >> Of course good for others to also evaluate. >> >> Regards, >> >> Adolf. >>
<Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
<dhcp.png><services.png><graph-example1.png><graph-example2.png>
