Hello,
I disagree with this patch.
I generally would like the IPsec interfaces to be around all the time whenever that is possible.
Your patch changes that so that the interfaces only become available when RED connects. That might be late, or might never happen.
Other software expecting those interfaces being available might have a problem then.
What is the saving here? Calling one extra script?
-Michael
On 23 May 2023, at 18:23, Jonatan Schlag jonatan.schlag@ipfire.org wrote:
This is called several times in the boot process. It also depends on connectivity to the internet. So there is no point in calling it here when we do not know if we even have an internet connection.
It is called in the ipsecctrl programm which is called in the start and shutdown process of red ( /etc/init.d/networking/red.down/10-ipsec and /etc/init.d/networking/red.up/50-ipsec).
Signed-off-by: Jonatan Schlag jonatan.schlag@ipfire.org
src/initscripts/system/network | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/initscripts/system/network b/src/initscripts/system/network index 9ef3fb0d8..7e457edfa 100644 --- a/src/initscripts/system/network +++ b/src/initscripts/system/network @@ -70,9 +70,6 @@ case "${DO}" in fi fi
- # Create IPsec interfaces
- /usr/local/bin/ipsec-interfaces
/etc/rc.d/init.d/static-routes start
boot_mesg "Mounting network file systems..."
2.30.2