Hello,
On Thu, 2015-08-13 at 15:00 +0200, Larsen wrote:
Hi Kim,
I have been using this for not so long either, but I can tell you that patches should be sent inline (no attachment) and you have to disable
Indeed, we can comment on an inline patch much easier. Patchwork however parsed the attachment correctly, so it is okay for this time.
line-wrap in your mail client. Some examples: http://patchwork.ipfire.org/project/ipfire/list/
On the thing itself: I saw the conversation on the IPFire forum and must say that I do not really get why all this information is needed on the web user interface. So I would like to discuss this first before looking closely at the patch.
Time: I get that this is a good information to know just to check if the clock of the system is running correctly. If the timezone needs to be included if it is local time is debatable.
Load: I do not really understand why this is an important information that should be on every single page of the web user interface. Most users do not even really understand the meaning of these values and often worry about numbers above a certain value they are used to.
I think this could be as well below the load graph.
Logged in users and uptime: There is no point in this. I wonder why you find this is important.
So this information is automatically updated by Javascript every other second. This will always return a wrong time because there is obviously lots of latency on the network. What is wrong with just embedding the time when the page was generated?
I just would like to hear your objective or opinion on this.
Best, -Michael
hth, Lars
On Thu, 13 Aug 2015 14:50:52 +0200, Xaver4all xaver4all@gmx.de wrote:
Hi all,
this is my first time using this mailing-list thing, so hopefully I do everything according to your CoC.
[PATCH] add actual system time and timezone info-bar to ipfire theme. position can be configured in GUI user-settings, default is off.
future reference, German discussion in forum: http://forum.ipfire.org/viewtopic.php?f=17&t=12177
attached is a patch against the actual next branch
br, Kim