Hi,
yes indeed.
But is not 100% necessary to pass the -p parameter with the PID file. I just removed that when ever it got difficult to use and did not even add that for new scripts.
But using $DEVICE is definitely wrong in the snort script.
-Michael
On Sun, 2017-04-23 at 19:20 +0200, Matthias Fischer wrote:
Hi,
while searching for something else I found this:
Usage for the 'killproc'-function in '/etc/init.d/'-files should be (cited):
"# Function - killproc [-p pidfile] pathname [signal] # # Purpose: # # Inputs: -p pidfile, uses the specified pidfile # pathname, pathname to the specified program ..."
But in the 'init'-files for 'dhcp', 'dhcrelay' and 'rndg' there is the PROGRAMname and in 'snort'-file '/var/run' is given. The latter leads to an error (FAIL) if both 'green0' and 'red0' are enabled and should be both stopped:
... killproc -p /var/run/dhcpd.pid /usr/sbin/dhcpd ^^^^^^ ... killproc -p /var/run/dhcrelay.pid /usr/sbin/dhcrelay ^^^^^^^^^ ... killproc -p /var/run/rngd.pid /usr/sbin/rngd ^^^^^ ... killproc -p /var/run/snort_$DEVICE.pid /var/run ^^^^^^^^
IMHO, all these should be changed to "pathname to the specified program" as cited above ('/usr/sbin').
Can anyone please confirm?
Best, Matthias