Re: Updated Updxlrator and other changes

Hello,

thank you very much for the patches you sent in. I had a look at them and they look fine (did not read through all the perl code).

Patches 0005 is a duplicate of 0004.

Who is now going to merge them to the git repository? I am running out of time to do that.

I reckon the changes won't make it to IPFire 2.13, which is done by now.

Michael

On Mon, 2012-12-24 at 09:24 +0100, Jörn-Ingo Weigert wrote:

Hi Michael,

2012/12/23 Michael Tremer michael.tremer@ipfire.org Hi Jörn,

    could you please provide patch files against the current
    development
    tree, so we can review the changes you made more easily.

Done, I'm not so familar with git and RCS in general, so take it easy and the files attached. don't know if git added the extra giffiles so added it too. put them into html/html/images/updbooster dir.

    Well, the WUI is not conform to any HTML standard, because too
    many
    people have put their code into it without agreeing on a
    coding style.

Well, I oriented me on the existing XHTML-Doctype in the current header.

    I personally consider this as a full-time job to fix all
    problem that
    there are and so, I don't want to put more time than necessary
    into it.
    Developing a new WUI from scratch is more important to me.

I agree with you, but hoping that coming versions of browsers will be lazy as now in interpreting not correct formed (x)html should not the right way. Better to point to the browser vendors then on our own code. ;) And its not much work (Hust) to test it with online validators.

    > 1. apache:

    > Modified /etc/httpd/conf/loadmodules.conf - enable
    mod_deflate for
    > compression the output files (except graphics) if browser
    supports it.
    > Modified /etc/httpd/conf/vhosts.d/ipfire-interface-ssl.conf
    - enabling
    > compression for whole SSL-Web interface


    Yeah, we can accept that one. Please send the patch.

Great :)

    > 2. Theme "ipfire" & "maniac":


    >    ....


    > These changes let perform google chrome like a charm
    rendering the
    > pages within ~15 secs like other browsers (tested with IE9,
    Opera,
    > Firefox in actual versions)
    > instead of waiting for minutes ...


    In case that does not break anything with older browsers, send
    a patch
    as well.

I didn't test it with IE <=7, or NNavigator nor MOSAIC ... well let's see.

    > 3. Web-UI in general and addons which use the "age"-function
    from
    > general-functions
    >
    >
    >  - modified age function to show the time translated, in
    single and
    > plural terms, but only the parts, which make sense.
    >    Example instead of showing: 0d 0h 47m 15s, it will show
    now: 47
    > Minutes, 15sec. in connection time


    I don't think that it makes any sense to print "minutes"
    instead of "m"
    because there is not enough space to do so.

    I agree that it makes sense to omit "0d" and "0h".

Well, it prints out only the first part in long form, all followed will be shortened

Examples

Old: 1d 2h 3m 4s New: 1 Day, 2 Hr, 3 Min, 4 Sec

Old: 0d 0h 1m 2s New: 1 Minute, 2 Sec.

    Yes there is, because those files have been changed recently.

I see.

    -Michael

Hope, this work now..

Kind regards,

nightshift _______________________________________________ Development mailing list Development@lists.ipfire.org http://lists.ipfire.org/mailman/listinfo/development