Hello,
Thank you for this checklist...
On 20 Aug 2024, at 11:13, Adolf Belka adolf.belka@ipfire.org wrote:
Hi Michael,
Here is the feedback on the UI from the latest nightly build of CU188.
On the Intrusion Prevention System WUI page it shows up as running. However on the Services WUI page the IPS still shows as Stopped.
Fixed. Suricata renames itself and so we cannot find a process “suricata” any more.
On the IPSec WUI page the Client Connection Status and Control table does not show the status of the connection in colour. This has been fixed on the OpenVPN WUI page but not yet for the IPSec page.
I thought I fixed this before, but I seem to have forgotten the “DISCONNECTED” state. This is now fixed, too.
On the Firewall Rules WUI page the alternating grey shades are not working well as the comment lines for each rule entry are being treated as a separate line to have the shade changed. This would be okay if all rules had remarks because then the rule line would be one shade and the remark line a different shade but consistent.
Yeah, this is indeed not idea. I have changed this so that it is the way before (by overwriting the automatic striping).
However you can also have a rule without a remark and then the shading swaps over. Also the remark line should be part of the rule number section. Currently the remarks are not part of a rule line. See the attached screenshot. Rule 1 is a white line and then rule 2, 3 & 4 are grey. The remarks for rules 2 & 3 are on white lines but as rule 4 does not have a remark then the following rule lines are now white and the remarks are grey.
This should now be fixed.
On my vm I have the samba addon installed and it has no colours for the status of the three daemons on its WUI page.
I have used the status widget for this now, too. I have allow refactored the form to use the new form styling.
I also have WIO and that looks all okay.
APCUPSD has a WUI page but it uses a compiled cgi page from apcups and won't be affected by the changes.
Yeah, that external stuff should be entirely unaffected.
The other addons with WUI pages are:
guardian
Guardian had the same service status problem, which I have fixed.
mpfire
This thing is so broken that I won’t even touch it.
mympd tor transmission vdr wlanap
I just installed guardian and the status part of the table has no colour. I don't know about the other addons as I have not used them before myself.
Regards,
Adolf.
<Screenshot_2024-08-20_12-01-17.png>
Okay, I have pushed all those changes now and I will merge next into master to get this release on the road…
We clearly have fixed all the major problems and if there are any more minor ones, we will catch them during the testing phase.
Thank you for your excellent help!
-Michael