Aw: [PATCH v3 3/4] proxy.cgi: strip newline from subnet parameters

Hi,

newlines have to be stripped from each line. Therefore the code should read: close(SUBNETS); }

foreach (@templist) { chomp; @temp = split(///);

- Bernhard

Gesendet: Mittwoch, 14. Februar 2018 um 20:35 Uhr Von: "Bernhard Held" berny156@gmx.de An: development@lists.ipfire.org Betreff: [PATCH v3 3/4] proxy.cgi: strip newline from subnet parameters

The subnets in @templist end with newlines. Theses have to be removed before printing and comparison with other subnets.

---

html/cgi-bin/proxy.cgi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi index 6aa14e15a..d565ffbdc 100644 --- a/html/cgi-bin/proxy.cgi +++ b/html/cgi-bin/proxy.cgi @@ -3061,6 +3061,8 @@ END close(SUBNETS); }

• 	chomp(@templist);
  

• foreach (@templist)
  {
  	@temp = split(/\//);
  

@@ -3069,7 +3071,6 @@ END ($temp[0] ne $netsettings{'BLUE_NETADDRESS'}) && ($temp[1] ne $netsettings{'BLUE_NETMASK'}) ) {

• 			chomp $temp[1];
  		print FILE " ||\n     (isInNet(myIpAddress(), \"$temp[0]\", \"$temp[1]\"))";
  	}
  }
  

-- 2.16.1