Re: [PATCH] Network::network_equal: fix definition check of array

On 02/12/2018 at 12:38 AM, Michael Tremer wrote:

Hello,

this patch shows the following perl errors:

defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114. (Maybe you should just omit the defined()?) defined(@array) is deprecated at config/cfgroot/network-functions.pl line 114. (Maybe you should just omit the defined()?)

Interesting, I'm testing on IPFire 2.19. Here perl 5.12 prefers the '$'. My host with Perl 5.26 indeed prefers the '@' as well.

Which perl versions apply for network-functions.pl?

You can use the testsuite at the bottom of the file to confirm that the functions are doing what they are supposed to do.

Thanks, this helps ;-)

Regards, Bernhard