Hi Matthias,
Matthias Fischer wrote:
Thank you for your response
...
Some findings:
- For keeping the "naming conventions" in '/etc/init.d', I'd suggest to
name this script just 'banish', not 'rc.banish'. This way it can be found more easily. Every other script in this dir is named accordingly to the program its starting/stopping...
rc.banish is the original IPCop name for the init script, but I can follow convention and change it to banish.
- With '1.0.2', installation throws no errors anymore, but I can't add
any IP-Addresses. List stays empty. And everytime 'BanishGeo.cgi' is opened, '/var/log/httpd/error_log' says:
***SNIP*** ... Usage: host [-aCdilrTvVw] [-c class] [-N ndots] [-t type] [-W time] [-R number] [-m flag] hostname [server] -a is equivalent to -v -t ANY -c specifies query class for non-IN data -C compares SOA records on authoritative nameservers -d is equivalent to -v -i IP6.INT reverse lookups -l lists all hosts in a domain, using AXFR -m set memory debugging flag (trace|record|usage) -N changes the number of dots allowed before root lookup is done -r disables recursive processing -R specifies number of retries for UDP packets -s a SERVFAIL response should stop query -t specifies the query type -T enables TCP/IP mode -v enables verbose output -V print version number and exit -w specifies to wait forever for a reply -W specifies how long to wait for a reply -4 use IPv4 query transport only -6 use IPv6 query transport only ... ***SNAP**
It seems there are some syntax errors in 'BanishGeo.cgi' (line 773!?).
After a bit of investigation, this is caused by a default blank entry creeping into the banish_config file presumably a CR/LF that shouldn't be there. If you delete the blank line in the BanishGeo.cgi display (with the dustbin icon all should be OK. I used a test banish_config file for my original testing and didn't see this error.
- $Lang::tr{'apply'} - used in 'BanishGeo.cgi' line 232 - is missing in
the language-files.
This is a problem with the original banish distribution files. Maybe there was a translation in IPCop which IPFire doesn't have, I'll add one to these lang files if I can find the appropriate translations.
- Uninstaller didn't remove '/var/ipfire/menu.d/EX-banish.menu' and
'EX-Banishlog.menu'. They're not shown anymore, but files are still there.
Looks like I missed those in the uninstall script. I'll add them.
- None of the given URLs is working here:
http://wiki.sidsolutions.net/ => "Can't be found". http://banish.sidsolutions.net is redirected to ww2.banish.sidsolutions.net => no answer...
I am aware that sidsolutions is no longer there and removed quite a lot of code with links to his site and must have missed these. Thank you for finding them.
In the original Banish there were 2 cgi control pages a Banish_Settings.cgi and the BanishGeo.cgi. For IPFire I combined the 2 pages which puts the Viewing Options box at the top of the BanishGeo.cgi page. Also in the original there were 2 optional Banish.cgi pages and the BanishGeo.cgi page was only installed if Geo::IP::PurePerl was installed. As IPFire seems to always install this I didn't bother with the non-Geo page.
HTH,
Yes it has, thank you very for your time to look at this. Look out for 0.3 which should have the errors corrected
Matthias
As an aside I'm running Core Update 126 on my test box and noticed what I think is a typo in log.dat for the captive translation entry. I think line 84 should be:
'captive' => $Lang::tr{'Captive'}, with a capital 'C' and not:
'captive' => $Lang::tr{'captive'},
Kind Regards
Rob