For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: /srv/web/ipfire/html/images/delete.gif /srv/web/ipfire/html/images/go-bottom.png /srv/web/ipfire/html/images/floppy.gif
On Mar 21, 2021, at 1:25 PM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>