Re: [PATCH] ddns: Add provider Feste-IP.Net

-- 2.31.0 Michael Tremer: > Hello Martin, > >> On 20 May 2021, at 17:51, Martin Krieger makrie@posteo.de wrote: >> >> Hello Michael, >> >> this is my latest improvement: >> >> From c745be038550bf66f2c233ff9de1348bcfd99080 Mon Sep 17 00:00:00 2001 >> From: Martin Krieger makrie@posteo.de >> Date: Tue, 18 May 2021 19:42:44 +0200 >> Subject: [PATCH] ddns: Add provider Feste-IP.Net >> >> Provider supports IPv4, IPv6 & DS (Dual-Stack). >> Required url parameter myip for IPv4 or IPv6. >> Optional url parameter myip2 for DS which holds IPv4 or IPv6. >> Url parameters myip & myip2 will not hold the same record type. >> --- >> README | 1 + >> src/ddns/providers.py | 40 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/README b/README >> index b6decb35c338..fa6ce5e598b8 100644 >> --- a/README >> +++ b/README >> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >> easydns.com >> enom.com >> entrydns.net >> + feste-ip.net >> freedns.afraid.org >> inwx.com|de|at|ch|es >> itsdns.de >> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >> index 56e6620c78ab..8c6da69b6e50 100644 >> --- a/src/ddns/providers.py >> +++ b/src/ddns/providers.py >> @@ -1179,6 +1179,46 @@ class DDNSProviderEntryDNS(DDNSProvider): >> raise DDNSUpdateError >> >> >> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >> + handle = "feste-ip.net" >> + name = "Feste-IP.Net" >> + website = "https://www.feste-ip.net/" >> + >> + # Information about the format of the request is to be found >> + # https://forum.feste-ip.net/viewtopic.php?f=13&t=469 >> + >> + # myip is required and holds IPv4 or IPv6 >> + # myip2 is optional for DS and holds IPv4 or Ipv6 but opposite record type of myip >> + myips = ("myip","myip2") >> + >> + url = "https://members.feste-ip.net/nic/update/" >> + >> + def update(self): >> + data = { >> + "hostname" : self.hostname >> + } >> + >> + # idx sets index of myips and checks for required url parameter myip >> + idx = 0 >> + # Loop through DDNSProvider.protocols list >> + for proto in DDNSProvider.protocols: >> + idx = 0 >> + tmpip = self.get_address(proto) >> + # Save only valid address response of protocol proto to the actual url parameter... >> + # and increase idx >> + if tmpip: >> + data[self.myips[idx]] = tmpip >> + idx += 1 >> + >> + # Send DynDNS2 update request if the required url parameter myip is given >> + if idx: >> + self.send_request(data) >> + return >> + >> + # Raise error if the required if the required url parameter myip gets no valid address >> + raise DDNSUpdateError >> + >> + >> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >> handle = "freedns.afraid.org" >> name = "freedns.afraid.org" >> -- >> 2.31.0 >> >> Based on your correct comment idx = 0 was on the wrong line, it moved outside the loop over the protocols (IPv4 & IPv6). > > You ignored all technical advice that I have given to you. There are solutions already in the same file that you simply need to copy and paste. They are tested, clean and just work. > > Your implementation is not very Pythonic and raises a random error if no IP address could be determined. > >> Pure IPv4 is tested & works as expected. As stated several times I have no option to test IPv6 and DS on my system. >> >> The provider serves a test possibility (https://www.feste-ip.net/ddns-service/faq-ddns/): >> >> "Kann Ich den Dienst testen ohne mich extra anzumelden? >> Ja. Um zu testen ob Ihr Router bzw. Ihr Updateclient mit unserem Dienst funktioniert können Sie folgende Testdaten verwenden: >> >> DNS-Name: test.feste-ip.net >> HOST-ID : 13135 >> Passwort: 7sN2KS6L8W >> >> Bitte beachten Sie dass diese Daten u.U. von mehreren Testern verwendet werden. >> Ob Ihr Update erfolgreich war können Sie mit der zeitnahen Eingabe von "nslookup -query=txt test.feste-ip.net" prüfen." >> >> Could please anybody in the development-team who has the right technical conditions (IPv6 or DS) do test for these cases? That would be nice. Thanks. >> >> Should I mark my faulty patch on the ipfire git server as superseded? > > Yes, please. > >> Regards, >> >> Martin Krieger >> >> Michael Tremer: >>> Hello, >>>> On 20 May 2021, at 12:02, Martin Krieger makrie@posteo.de wrote: >>>> >>>> Hello Michael, >>>> >>>> got it. You are right, sorry for confusion. >>>> >>>> But I really read the process description and have read your comments as well as looking in providers.py for examples. >>>> >>>> What should I do? Remove anything, improve it,...? >>> Yes, please improve the patch. If there is anything unclear, you should >> ask those questions first before sending a fixed version of that patch. >>>> Simply issue a request to you to implement that? >>> No, this won’t work because we don’t have an account with this provider to test it. >>>> One general question: Should a patch be send as uncommited diff from the staging area in before for revision instead of a commited one? >>> No, you should have a branch in your local git repository and commit to >> that. You can use “git commit —-amend” if you need to edit an existing commit. >>> Best, >>> -Michael >>>> >>>> Regards, >>>> >>>> Martin Krieger >>>> >>>> >>>> >>>> Am 20. Mai 2021 12:00:26 MESZ schrieb Michael Tremer michael.tremer@ipfire.org: >>>> Hello Martin, >>>> >>>> Thanks for working on ddns, but *please* read Peter’s email. >>>> >>>> This is now the third patch (I don’t know why you are at number 6 already) and the idea of the review process is to submit something that at least works. You can ask all sorts of questions about anything you need to know, but you will have to listen to what people answer. >>>> >>>> This patch is fundamentally broken. I will comment on that further below. >>>> >>>> Secondly, we cannot even think about merging something that isn’t tested at all. >>>> >>>> So I would urge you to look at any of the other providers, because what you are trying to implement has already been implemented here for example: >>>> >>>> https://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/providers.py;h=56e6620c... >>>> >>>> @Stefan: We might want to have a class variable in the DynDNS protocol >> that adds the IPv6 address to a field that is named in that variable. That way, we avoid any code duplication. >>>> >>>> On 18 May 2021, at 19:49, Martin Krieger makrie@posteo.de wrote: >>>> >>>> From 37fb0237932fb12bdd635e9cb5e01b0bf9f03dda Mon Sep 17 00:00:00 2001 >>>> From: Martin Krieger makrie@posteo.de >>>> Date: Tue, 18 May 2021 19:42:44 +0200 >>>> Subject: [PATCH v6 1/1] ddns: Add provider Feste-IP.Net >>>> >>>> Comments: >>>> Provider supports IPv4, IPv6 & DS (Dual-Stack) >>>> >>>> Changelog: >>>> >>>> 18.05.2021 >>>> Improved failure handling. >>>> IPv6 & DS still not checked, because my network connection is pure IPv4. >>>> >>>> 17.05.2021 >>>> 5th attempt ([PATCH v5 1/1]) >>>> >>>> 16.05.2021 >>>> 4th attempt ([PATCH v4 1/1]) >>>> >>>> 08.05.2021 >>>> 3rd attempt ([PATCH v3 1/1]) >>>> >>>> 06.05.2021 >>>> 2nd attempt ([PATCH v2 1/1]) >>>> >>>> 05.05.2021 >>>> 1st attempt ([PATCH v1 1/1]) >>>> >>>> Signed-off-by: Martin Krieger makrie@posteo.de.. >>>> README | 1 + >>>> src/ddns/providers.py | 31 +++++++++++++++++++++++++++++++ >>>> 2 files changed, 32 insertions(+) >>>> >>>> diff --git a/README b/README >>>> index b6decb35c338..fa6ce5e598b8 100644 >>>> --- a/README >>>> +++ b/README >>>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >>>> easydns.com >>>> enom.com >>>> entrydns.net >>>> + feste-ip.net >>>> freedns.afraid.org >>>> inwx.com|de|at|ch|es >>>> itsdns.de >>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>> index 56e6620c78ab..b7e14482a0b1 100644 >>>> --- a/src/ddns/providers.py >>>> +++ b/src/ddns/providers.py >>>> @@ -1179,6 +1179,37 @@ class DDNSProviderEntryDNS(DDNSProvider): >>>> raise DDNSUpdateError >>>> >>>> >>>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >>>> + handle = "feste-ip.net" >>>> + name = "Feste-IP.Net" >>>> + website = "https://www.feste-ip.net/" >>>> + >>>> + # Information about the format of the request is to be found >>>> + # https://forum.feste-ip.net/viewtopic.php?f=13&t=469 >>>> + >>>> + myips = ("myip","myip2") >>>> + >>>> + url = "https://members.feste-ip.net/nic/update/" >>>> + >>>> + def update(self): >>>> + data = { >>>> + "hostname" : self.hostname >>>> + } >>>> + >>>> + for proto in DDNSProvider.protocols: >>>> + idx = 0 >>>> + tmpip = self.get_address(proto) >>>> + if tmpip: >>>> + data[self.myips[idx]] = tmpip >>>> + idx += 1 >>>> >>>> Setting idx is useless here. You will reset to zero in every iteration >> of the loop. Since it is being incremented last and then reset to zero, idx will *always* be zero. >>>> >>>> + >>>> + if self.myips[0] in data: >>>> + self.send_request(data) >>>> + return# >>>> >>>> You will only send one request here and only if it contains an IPv4 address. Why? What happens to systems that only have IPv6? >>>> >>>> -Michael >>>> >>>> + >>>> + raise DDNSUpdateError >>>> + >>>> + >>>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>>> handle = "freedns.afraid.org" >>>> name = "freedns.afraid.org" >>>> -- >>>> 2.31.0 >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet. >> >