Hey Rob,
Please only attach patches inline. That way, people can comment on them directly.
If I now write things like:
In the first file, line 12, something is not right there…
then nobody knows what I am referring to.
Best, -Michael
On 10 Feb 2019, at 16:07, Rob Brewer ipfire-devel@grantura.co.uk wrote:
Hi Michael
Rob Brewer wrote:
However, I do not think that this is a bad idea, but it should be configurable on the firewall options page.
Yes I was thinking that this could be easily select-able with an if statement around the LOG line if required.
OK I've been working on your suggestion and have added an additional checkbox to the GeoIP Block of geoip-block.cgi to enable/disable logging.
(patch: geoip-block.cgi)
I have also reworked rules.pl to enable geoip-block logging from geo- block.cgi.
(patch: rules2.pl)
Rob <geoip-block.cgi><rules2.pl>