On Thu, Dec 13, 2018 at 09:06:06PM +0000, Bob Brewer (ipfire-devel@grantura.co.uk) wrote:
There are some weird domains in there and many are new to me so maybe my patch needs to be updated to allow for these but I notice that there aren't any purely numeric TLDs in that list.
No, and I don't expect such in the next new gtld round either, though some with embedded numbers might appear.
I assume that those will no longer be usable after your patch. Can you confirm that?
MY patch brings IPfire's validfqdn to be the same as the one in the latest IPCop version. It looks like we need to add a '-' to the regex string to make comply with the domains listed above.
Dash (-) should be allowed except in the beginning and end (that applies to other parts of the fqdn, too, but there pure numeric ones can also occur).
It would also be good to think where non-ASCII names should be allowed without requiring user to convert them to punycode first.