Hello Jonatan,
On 20 May 2024, at 10:05, Jonatan Schlag jonatan.schlag@ipfire.org wrote:
Hi list,
This is the first patch series for the roadmap item: https://www.ipfire.org/docs/roadmap/get-rid-of-configtype-in-network-config . This patch series introduces a bash testing library and a function readhash, which we will use in every bash script which needs to read our config files. As this patch set is already massive, I thought it might be better to discuss the function first before I introduce it in every script. Otherwise, we would talk about 50 patches and not 21. This amount would be somehow not reviewable. If this patch series get merged, fine. If you want to wait for all the patches also fine, but as told, this will get a huge patch set.
Yes, I am happy to have smaller patch sets so that we get those changes shipped. They have so many advantages. We must however not forget to continue working on those projects after the first steps have been merged, otherwise we have tons of dead code in the distribution.
I will reply to the individual patches.
Generally, this is too many emails. I think you might want to condense things slightly more using “git rebase -i” to squash fixups together with the original commit.
-Michael
Patches in this series are:
[PATCH 01/21] test: Add bash lib for colors [PATCH 02/21] tests: Add bash lib [PATCH 03/21] tests/lib.sh: Add function [PATCH 04/21] tests/lib.sh: Add check if variable exists to [PATCH 05/21] tests/lib.sh: Add logging functions [PATCH 06/21] tests/lib.sh: adjust to pytest logging style [PATCH 07/21] tests/lib.sh: Fix check if array is defined [PATCH 08/21] test_that_key_in_arry_has_value: Check if the key is [PATCH 09/21] tests/lib.sh: Use namref to access an array [PATCH 10/21] test_that_key_in_arry_has_value: Check if a key in an [PATCH 11/21] tests: Add function to test the ouput of a bash [PATCH 12/21] initscript functions: add readhash [PATCH 13/21] initscript fkt: ignore blank lines in readhash [PATCH 14/21] test: Add functions test_that_array_is_defined [PATCH 15/21] tests: Add functions test_that_array_doesnt_have_key [PATCH 16/21] initscripts fkt: Ignore comments in readhash [PATCH 17/21] initscripts fkt: ignore invalid keys in readhash [PATCH 18/21] initscripts fkt: readhash should only parse lines with [PATCH 19/21] initscripts fkt: Check for invalid values in readhash [PATCH 20/21] initscripts fkt: keep readhash compatible with older [PATCH 21/21] initscripts fkt: Fix shebang
Greetings Jonatan