(I changed the subject as this has nothing to do with pppsetup.cgi)
On Thu, 04 Jun 2015 18:23:07 +0200, Michael Tremer michael.tremer@ipfire.org wrote:
If I remove the first space from every line of the diff that does not start with a + or - character. Any idea how this comes?
TL;DR: Opera 12.17 f*cks up the patch when sent as plain text.
1) I took the file that TortoiseGit saved, saved the text I sent to the list, the text I received from the list, and the file that Michael sent back. 2) Edited all of them to start with these lines: --- a/html/cgi-bin/vpnmain.cgi +++ b/html/cgi-bin/vpnmain.cgi 3) Converted the saved mails to UNIX format with LF instead of CRLF (Windows here) 4) Calculated md5sums: They were all the same except for the one sent to the list
Examining this further, I noticed a bug in my mail program when it displays the mail in the "sent" folder: When there is more then one line beginning with a space char, the mailer will put a superfluous space character into the beginning of the last line. Strange as hell, but this only affects the display here.
Then, I switched views to have the header displayed, too, and saved it as a file. Compared to the file created by TortoiseGit and now I can solve this riddle: There we have superfluous whitespace in front of every line without a + or - (as you noticed before).
I now also compared the mail I received as it is shown in my mail program and the bug is present there, too. Display is ok (even without that one extra space char - that is why the md5sum was ok first), but not when I display it with headers (raw view so to say).
Will send the next patches with Thunderbird and hope that it will be ok then. Wasted about an hour examining this - hope you guys at least had fun reading ;-)
Lars