Re: [PATCH] bug#10629: Prevent dynamic and fixed leases overlapping

On Feb 21, 2021, at 9:02 AM, Adolf Belka (ipfire) adolf.belka@ipfire.org wrote:

Hi Michael & Tom

[snip]

I think the suggestion to only have a warning for existing overlapped leases and an error for creating new ones is a good solution. It allows existing systems with overlapped IP's to continue running but makes the issue visible. The error message to prevent creating new overlapped IP's makes sure that the problem is not extended further.

Regards,

Adolf.

Adolf,

So long as the user isn’t forced to change pre-existing fixed leases before adding new ones, this is fine by me, a good compromise, I suppose.

Perhaps it would be wise to highlight any rows that do over lap to alert the user that they should endeavor to fix them?

Tom