Hi Michael,
Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
I don't know what is going on here.
----------------------------------------------
Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
On the Services page the first graph which should be titled Processes is labelled 100%.
On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
The following menu items showed longer entry boxes that overlap labels or other elements DHCP DNS Forward Static Routes Wake on LAN Time Server Log Settings Proxy Logs
The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example Firewall Groups Firewall Options Blue Access Log Summary Dynamic DNS Proxy reports Firewall logs Firewall graphs - IP, Port & Country IPS Logs IP Address blocklist logs OpenVPN RW logs URL Filter Logs System Logs Captive portal Connection Scheduler Assign MAC Address
The following menu items showed no change/issues except maybe for the graph period selection buttons . Backup Shutdown Credits Mailservice Memory Media Network External, Internal and Other OpenVPN RW and N2N Statistics WIO Hardware graphs Connections Mdstat DNS Web Proxy URL Filter Update Accelerator Edit Hosts QOS IP Address Blocklist Location Block IPTables
I am really sorry for giving false hope that the cleanup branch had gone really well.
Regards,
Adolf.
On 01/08/2024 12:50, Adolf Belka wrote:
Hi Michael,
On 25/07/2024 12:28, Adolf Belka wrote:
Hi Michael,
On 25/07/2024 10:44, Michael Tremer wrote:
Hello Adolf,
Thank you for getting back on this so quickly.
Maybe I got back too quickly!!
I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
Downloading the iso today from the latest directory gives me the build ed2c97b7.
I am going to install that version now but I suspect it will show the same as I found with my build.
So it looks like my original review was based on the version before the cleanup branch changes were included.
I will come back with new feedback of what I find from the latest branch that I have now downloaded.
Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
Regards,
Adolf
I suppose this also means that the ISO in the next branch boots just fine, too?
Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all. This tested out raid and all 4 interfaces.
Regards, Adolf.
Best, -Michael
On 25 Jul 2024, at 09:07, Adolf Belka adolf.belka@ipfire.org wrote:
Hi Michael,
I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
Of course good for others to also evaluate.
Regards,
Adolf.
