Hi Peter
Peter Müller schreef op do 28-07-2022 om 13:51 [+0000]:
Hello Robin,
thanks for your mail, the second version of this patchset, and marking the first version as "superseded" in Patchwork. :-)
I just merged the patchset into "next", so everyone running on the "unstable" tree can see the changes and test them. Commit 3543c24f41027c6e4437b8d1b3d3ca75d47ed3c9 should ship all the files you changed, please let me know in case I forgot anything.
I think, aside from de localization files, you have them all. I'm not completely sure what this rootfile is you modified here? Are those all files that differ since last core update ? But I asume lang files are then handled somewhere else ?
Robin
All the best, Peter Müller
Hi all
As promised a revision of this patchset by the end of July. Also fixing bug #12868, both in patch 01 (installed: yes/no output) and patch 06 (don't trow error on valid '--no-color' option).
This is quite a large patchset on delicate code which was discussed upon previous submission, but that was almost half a year ago. So I will try to link references to discussions on my previous submission where appropriate to refresh some memories :-).
What was changed since last submission; implementing/fixing Michael's remarks/concerns:
- Patch 01: Added translations as requested here:
https://lists.ipfire.org/pipermail/development/2022-March/012782.html
- Patch 02: New patch translating WUI header/footer text
- Patch 03: (previously patch 02) was not changed
- Patch 04: (previously patch 03) replaced a forgotten
fetchfile/move combo by new getmetafile function
- Previous patch 04 was removed as the function
coreupdate_available turned out no longer used. See: https://lists.ipfire.org/pipermail/development/2022-March/012884.html
- Patch 05: Replaced seq shell command by perl seq-method,
consistent use of 'Core-Update' as requested here: https://lists.ipfire.org/pipermail/development/2022-March/012787.html
- Patch 06: Added exitcode to pakfire list as requested here:
https://lists.ipfire.org/pipermail/development/2022-March/012787.html Also exit with error when an unknown parameter is passed to pakfire list Added a small fix (in my opinion): log termination of pakfire inside END block
- Patch 07: Removed function coreupdate_available as it was
concluded that it was no longer needed (see again: https://lists.ipfire.org/pipermail/development/2022-March/012884.html ) Added meaningfull status exit code as remarked here: https://lists.ipfire.org/pipermail/development/2022-March/012788.html Split previous patch 07 pakfire.cgi changes in new patch 08:
- Patch 08: New patch, previously part of patch 07
Fixed localization as pointed out here: https://lists.ipfire.org/pipermail/development/2022-March/012788.html
- Patch 09: (previously patch 08) Split previous patch 08 into
patch 09 adding 'getmetadata' function and 'pakfire info' and patch 10 implementing the new 'getmetadata' in service.cgi. Show clean warning message when no packages are found with requested pakfire list filter
- Patch 10: (previously part of patch 08) Removed hardcoded
exclusions in services.cgi as pointed out here: https://lists.ipfire.org/pipermail/development/2022-March/012789.html Previous patch 09 was dropped from this patchset as there turned out to be major problems with it and should be rethinked as pointed out here: https://lists.ipfire.org/pipermail/development/2022-March/012856.html
I think I have tested this all throughly but as these are quite interusive changes to the pakfire core workings; Please do not trust my testing and test these patches yourselves during review. I would not want to carry the responibilities of breaking pakfire alone :-)
Regards Robin