Re: [PATCH] qos.cgi: Fix truncated status output

Reviewed-by: Michael Tremer michael.tremer@ipfire.org

On 30 Jul 2021, at 19:57, Stefan Schantl stefan.schantl@ipfire.org wrote:

In the past only the fist line of the status output has been passed to the cleanhtml() function and displayed. Now the whole output will be converted to a string, cleaned and displyed on the WUI again.

Fixes #12666.

Signed-off-by: Stefan Schantl stefan.schantl@ipfire.org

html/cgi-bin/qos.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi index fa566b523..d768f95f5 100644 --- a/html/cgi-bin/qos.cgi +++ b/html/cgi-bin/qos.cgi @@ -543,7 +543,7 @@ elsif ($qossettings{'ACTION'} eq $Lang::tr{'status'} ) if ($qossettings{'ENABLED'} eq 'on'){ my $output = ""; my @output = &General::system_output("/usr/local/bin/qosctrl", "status");

• $output = &Header::cleanhtml(@output[0],"y");
  

• $output = &Header::cleanhtml(join("", @output), "y");
  

  print "<pre>$output</pre>\n"; } else { print "$Lang::tr{'QoS not enabled'}"; } &Header::closebox();

-- 2.30.2