Hi Matthias,
[Good morning Erik, - at this time I had already been busy for ~6 hours, *sigh* ;-) ]
and two hours before i went to sleep ;-) , puhh the whole live is work.
i have found some other files which i have missed in the check. I recognized it as i checked the OpenVPN Net-to-Net Statistics in netovpnsrv.cgi where the the descriptions
I thought that we missed some files…
Yes had/have that feeling too.
Incoming Traffic Incoming Overhead Incoming Compression Outgoing Traffic Outgoing Overhead Outgoing compression
has also been reverted. The variables aren´t located in the CGIs nor in the menu directory, the graphs.pl is responsible for that. I decided then to make a walk through IPFires Github and have searched for $Lang and found some other locations. Have updated the script now, you can find the changes as before in here --> https://github.com/ummeegge/scripts/blob/master/langsCleaner.sh , the script needs on my JNC9C now 43 minutes, may too much checked files but better then not enough.
ACK.
Regarding the addon langs (possibly in general), it might be may an idea to check them also in the development chroot environment where all addons are already present?
Yep. Perhaps I have some time to dig into this on weekend. For now, days are full... ;-(
No problem at all, it was just a support for your intend.
If the langs would be checked directly in the development environment, there is the chance to get them all and check all at once.
As i can see it concerns only Guardian and the Squid Accounting Feature (WIO also but this is currently no official IPFire Addon).
WIO should become official, IMHO. It should be included and dealt with. (Beware of my english...: Also, ich meine - Ja, wir sollten da halt auch ein Auge drauf haben).
Klar können wir machen. I tried that already and have found also there not used strings but i´am currently not sure if 1) really got all files and 2) if the development in those addons are finished ?! So the possibility might there that some strings are used further?! May both Stefans and Alexander do have also some infos for this.
This all will needs surely a deeper look.
As written: ACK! ;-)
Greetings,
Erik
Am 06.02.2017 um 21:01 schrieb Matthias Fischer matthias.fischer@ipfire.org:
On 06.02.2017 20:50, ummeegge wrote:
Hi Matthias,
Besides, you're acting in the future already: "$date: 03.05.2017"!? ;-))
oh, possibly it is just warmer then ?! My bad sorry...
No problem - we're just a few steps ahead of the others. ;-)
A week of work has started, and "she seems to be kind of bad-tempered"…
Looks here very similar.
*sigh*
Some thoughts: I saw, your script uses "grep -FR" to build the string lists, so that the *.dat-files in '/srv/web/ipfire/cgi-bin/logs.cgi' are included in the search!?
Yes this was also an intend.
Ok. Good. ;-)
What about the strings in '/var/ipfire/addon-lang/*.pl'?
This one i haven´t recognize until now, good that you mentioned it, may this directory can be used in the same way then the others ?!
I think so, but will have a look at the corresponding CGI-files. Otherwise I fear that changed or obsolete strings from these files may occur again.
Feel greeted,
You're welcome!
Best, Matthias