Hi Stefan,
I merged this one (with a couple of cleanups) and the other new providers in your repository as well.
Please double-check if I resolved all merge conflicts correctly and that everything still works for you.
Best, -Michael
On Sat, 2014-06-14 at 19:10 +0200, Stefan Schantl wrote:
Hello Michael and list followers,
during my work on integrating several dynamic dns providers I've rewritten the code for the dyndns.org provider.
I've included your suggestions and was able to do some testing by using the provided test accounts from dyndns.org (http://dyn.com/support/developers/test-account/)
I've pushed the changes to my personal git repository, they can be found here:
http://git.ipfire.org/?p=people/stevee/ddns.git;a=blobdiff;f=src/ddns/provid...
Please have a look on them and merge the changes to the main ddns git repository so we can support this provider.
Best regards,
-Stefan
Hey Stefan,
thanks for your contribution so far. I have found several problems, which need to be fixed:
- We cannot possibly accept any code which has not been tested. Please
go and look for some people who can do that if you cannot do it on your own.
- In the URL, you created are some options, which are deprecated as it
is explained here http://dyn.com/support/developers/api/perform-update/. You should not introduce already deprecated functionality.
So, I suggest to drop "wildcard", "mx" and "backupmx" from the URL.
- As it is listed here
http://dyn.com/support/developers/api/return-codes/, there are a lot of return codes, which are not catched. You should consider to implement some of them which might be useful for the users like "nofqdn" or "nohost". I would cosider "dnserr" as mandatory.
Michael
On Sun, 2012-09-09 at 19:34 +0200, Stefan Schantl wrote:
Hello guys,
i've created a patch for the Dynamic DNS client for IPFire. (http://git.ipfire.org/?p=oddments/ddns.git;a=summary)
My patch will add support for the very popular "dyndns.org" provider. However I wasn't able to test my changes, because I don't have any account there and I seems new members have to purchase to use use it.
So, I need your help to test my changes and finally be able to support that provider in the next major version of IPFire.
Best regards,
Stefan _______________________________________________ Development mailing list Development@lists.ipfire.org http://lists.ipfire.org/mailman/listinfo/development