Hi Any news on this? Or should I try to submit the patch straight to git ? Or just have a bit more patience? (I will be on vacation starting tomorrow for about a month..so I won't be able to resubmit it then until next month) Robin Michael Tremer schreef op za 26-06-2021 om 13:09 [+0100]:
Hello,
On 25 Jun 2021, at 00:04, Robin Roevens robin.roevens@disroot.org wrote: It seems patch 2/2 of this set is rejected by the mailserver: 554 5.7.1 Rejected due to policy violation: Contains blacklisted URL.
Yes, our mail server seems to do that a lot recently.
For as far as I can see, the patch does not contain any URL's of anysort. How should I proceed from here? Is there an alternative way to submitthis patch-set? Or can it be checked what triggers this mailservererror ?
You have done the right thing by copying postmaster. Peter and I had a brief discussion about this yesterday. Let’s see what he says after looking at some logs. Best,-Michael
RegardsRobin Robin Roevens schreef op vr 25-06-2021 om 00:50 [+0200]:
Hi As discussed earlier, I hereby submit a patchset adding extra metadata to all pak's. First patch adds the new metadata fields "Summary" and "Services" tothe meta-file templates and introduces the new macro INSTALL_INITSCRIPTS accepting a space seperated list of initscripts to install to avoidduplicating the list of service initscripts. (Once in the new SERVICESmeta-data field and once by calling INSTALL_INITSCRIPT for each of them).The original INSTALL_INITSCRIPT macro is kept (and called by the newmacro) for corner cases where non-service initscripts need to be installed and for use by non-pak lfs files as they currently don't havea SERVICES variable. The second patch adds the new metadata for all pak's in theirrespectivelfs files. As I went over all pak lfs files, I did not encounter any corner caseshence all calls to INSTALL_INITSCRIPT are replaced by calls to the newINSTALL_INITSCRIPTS passing the SERVICES variable as argument.The only special case maybe worth mentioning is Icinga, where a serviceinitscript is installed by a make rule of the source. Hence no call toINSTALL_INITSCRIPT or INSTALL_INITSCRIPTS is required. But the serviceis included in the SERVICES variable to have it recorded in the meta-file. This set does not yet contain changes in pakfire or services.cgi toactually do something with the new meta-data.Those changes will be posted shortly. Regards Robin
-- Dit bericht is gescanned op virussen en andere gevaarlijkeinhoud door MailScanner en lijkt schoon te zijn.