Hi,
I couldn't help but notice this commit - not merged yet, but interesting: ;-)
https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961...
I tested and found something.
1. In 'netother.cgi' I changed: ... &Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'}); ...
To: ... &Header::openbox('100%', 'center', $Lang::tr{'connnections'}); ...
Reason: In german language (e.g.), 'connection tracking' is translated to 'iptables-Verbindungsverfolgung'. This string is too long for the box, so there is no headline, nothing.
I shorted this to 'connections', which is translated to 'Verbindungen' - and now the box has a headline. It took some time to figure this out.
2. In 'graphs.pl' I changed: ... "-t $Lang::tr{'connection tracking'}", ...
To: ... "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"}, ...
3. This triggered some commits, because in this context I found that the graph links for 'disk access', 'hardware', and 'entropy' differed. E.g.: https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba86...
As a side effect, it seems that the cpu frequency went up => see attachment.
Besides, graphs are looking good => see attachment.
Jm2c!
Best, Matthias
Hello,
On 23 Aug 2020, at 16:36, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
I couldn't help but notice this commit - not merged yet, but interesting: ;-)
https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961...
Yes. I emailed it to the list, too.
You can directly reply to those patches :)
I tested and found something.
- In 'netother.cgi' I changed:
... &Header::openbox('100%', 'center', $Lang::tr{'connnection tracking'}); ...
To: ... &Header::openbox('100%', 'center', $Lang::tr{'connnections'}); ...
I found “Connections” a little bit imprecise and preferred “Connection Tracking”, because that is more of less what we are doing here.
Reason: In german language (e.g.), 'connection tracking' is translated to 'iptables-Verbindungsverfolgung'.
Yes, I would propose we drop the “iptables” bit from this string. For all languages.
This string is too long for the box, so there is no headline, nothing.
I shorted this to 'connections', which is translated to 'Verbindungen' - and now the box has a headline. It took some time to figure this out.
- In 'graphs.pl' I changed:
... "-t $Lang::tr{'connection tracking'}", ...
To: ... "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"}, ...
That is probably helpful and in sync with the other graphs.
I got inspired by the entropy graph and that will probably have the same problem.
- This triggered some commits, because in this context I found that the
graph links for 'disk access', 'hardware', and 'entropy' differed. E.g.: https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba86...
Great. See above.
As a side effect, it seems that the cpu frequency went up => see attachment.
Interesting. That should obviously not happen when you only change the description. Are there any processes suddenly using a lot of CPU?
Besides, graphs are looking good => see attachment.
Yay!
Jm2c!
Best, Matthias <connection_tracking - day.png><cpu_frequency - week.png>
Hi,
On 24.08.2020 16:02, Michael Tremer wrote:
Hello,
...
https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961...
Yes. I emailed it to the list, too.
Hrm. I read it, but wasn't sure where to answer.
You can directly reply to those patches :)
Is it ok for now if I stay in this thread?
I tested and found something. ...
Yes, I would propose we drop the “iptables” bit from this string. For all languages.
Changed. Headline is still ok.
...
- In 'graphs.pl' I changed:
... "-t $Lang::tr{'connection tracking'}", ...
To: ... "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"}, ...
That is probably helpful and in sync with the other graphs.
I got inspired by the entropy graph and that will probably have the same problem.
Yes. Fixed. ;-)
- This triggered some commits, because in this context I found that the
graph links for 'disk access', 'hardware', and 'entropy' differed. E.g.: https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba86...
Great. See above.
As a side effect, it seems that the cpu frequency went up => see attachment.
Interesting. That should obviously not happen when you only change the description. Are there any processes suddenly using a lot of CPU?
I'm not sure - I didn't find such process. Perhaps this is due to the newly activated conntrack plugin from 'collectd'?
I'll test this ... done.
After I commented the line 'LoadPlugin conntrack' in '/etc/collect.conf' and restarted 'collectd', the CPU frequency immediately dropped. => see attachment.
Hm!? How do we handle this?
By the way: what would be the best method to merge this: *your* patch(es) and *my* changes?
Best, Matthias
Hi,
On 24 Aug 2020, at 19:11, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
On 24.08.2020 16:02, Michael Tremer wrote:
Hello,
...
https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=commit;h=4bf0d000ffe961...
Yes. I emailed it to the list, too.
Hrm. I read it, but wasn't sure where to answer.
You can directly reply to those patches :)
Is it ok for now if I stay in this thread?
Oh yes, absolutely.
I tested and found something. ...
Yes, I would propose we drop the “iptables” bit from this string. For all languages.
Changed. Headline is still ok.
...
- In 'graphs.pl' I changed:
... "-t $Lang::tr{'connection tracking'}", ...
To: ... "-t ".$Lang::tr{'connection tracking'}." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"}, ...
That is probably helpful and in sync with the other graphs.
I got inspired by the entropy graph and that will probably have the same problem.
Yes. Fixed. ;-)
- This triggered some commits, because in this context I found that the
graph links for 'disk access', 'hardware', and 'entropy' differed. E.g.: https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba86...
Great. See above.
As a side effect, it seems that the cpu frequency went up => see attachment.
Interesting. That should obviously not happen when you only change the description. Are there any processes suddenly using a lot of CPU?
I'm not sure - I didn't find such process. Perhaps this is due to the newly activated conntrack plugin from 'collectd'?
I'll test this ... done.
After I commented the line 'LoadPlugin conntrack' in '/etc/collect.conf' and restarted 'collectd', the CPU frequency immediately dropped. => see attachment.
Hm!? How do we handle this?
Hmm, the plugin is actually very simple:
https://github.com/collectd/collectd/blob/collectd-4.10/src/conntrack.c
It opens /proc/sys/net/netfilter/nf_conntrack_count and reads the value in it and writes it to the RRD database.
By the way: what would be the best method to merge this: *your* patch(es) and *my* changes?
Checking out my branch and committing your things on top of it I would say:
https://git.ipfire.org/?p=people/ms/ipfire-2.x.git;a=shortlog;h=refs/heads/c...
Best, Matthias <loadplugin_conntrack_commented.png>
-Michael
-
Matthias Fischer -
Michael Tremer