Hi Alf,

indeed the quality of the generated HTML of the CGI scripts is a mess.

That is one of the main reasons, why we decided to ditch the webUI as it is now and rewrite it from scratch in IPFire 3 in Python.

The new theme that comes with IPFire 2.15 (next branch) comes with the HTML5 doctype and a lot of code has been improved, but I think we are still far away from valid output. I would welcome any patches that fix the generated HTML, but I don't think that someone should put too much effort in it and rewrite bigger chunks of code.

-Michael

On Tue, 2014-02-11 at 19:26 +0100, Alf Høgemark wrote:

Hi

I was trying to validate the html pages of the web GUI of Ipfire. Although having pages that passes a validator is not absolutely requried, I think it makes styling easier, and it makes good sense to make sure table cells and rows are properly closed etc etc. It is a kind of indicator of code quality.

I then noticed that the ipfire web GUI is using the doctype for xhtml strict.

But the actual html itself seems to be a bit old style, with lots of align, valign attributes on tags, which will not validate as xhtml, even if all the tags are properly closed.

Have you considered going for "html5" doctype ? Using html5, I think it would require a lot less cleanup to make the pages validate.

And when a page validates, it makes it easier to test the page using a validator after you make code changes, to make sure it still validates.

Regards Alf Høgemark _______________________________________________ Development mailing list Development@lists.ipfire.org http://lists.ipfire.org/mailman/listinfo/development