Hello,

On 5 Apr 2021, at 12:35, Peter Müller peter.mueller@ipfire.org wrote:

Hello development folks,

since I am currently working on a patch(set?) allowing to enable the web proxy for ORANGE through the web interface,

And why would that be a good idea?

I stumbled across lines 3603 to 3613 in the proxy.cgi file:

...

if ($netsettings{'BLUE_DEV'}) { print FILE "delay_access 1 allow IPFire_green_network"; if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; } print FILE "\n"; print FILE "delay_access 1 deny all\n"; } else { print FILE "delay_access 1 allow all"; if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; } print FILE "\n"; }

This block appears odd to me, particularly due to the block in lines 3615 to 3625:

...

if ($netsettings{'BLUE_DEV'}) { print FILE "delay_access 2 deny IPFire_ips\n"; if (!-z $acl_src_unrestricted_ip) { print FILE "delay_access 2 deny IPFire_unrestricted_ips\n"; } if (!-z $acl_src_unrestricted_mac) { print FILE "delay_access 2 deny IPFire_unrestricted_mac\n"; } if (($proxysettings{'AUTH_METHOD'} eq 'ncsa') && (!-z $extgrp)) { print FILE "delay_access 2 deny for_extended_users\n"; } print FILE "delay_access 2 allow IPFire_blue_network"; if (!-z $acl_dst_throttle) { print FILE " for_throttled_urls"; } print FILE "\n"; print FILE "delay_access 2 deny all\n"; }

While the entire CGI is rather - um - hacky at some points, I suspect the first code block to be related to throttling on GREEN, which is not involved into the presence or absence of the BLUE interface. Or am I missing something here?

It is indeed a file that has been worked on over decades. It isn’t cut from just one piece of marble, but made out of many small pieces.

However, I do not know what you are asking. What does “odd code” mean?

-Michael

Thanks, and best regards, Peter Müller