There is no sense in instructing "trap" to catch signals it cannot trap whatsoever.
Signed-off-by: Peter Müller peter.mueller@ipfire.org --- make.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/make.sh b/make.sh index 4dd068e4b..c06b4ec38 100755 --- a/make.sh +++ b/make.sh @@ -437,7 +437,7 @@ prepareenv() { fi
# Trap on emergency exit - trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT + trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
# Checking if running as root user if [ $(id -u) -ne 0 ]; then
Hello,
Is this a cosmetic change or does this fix a real world problem?
-Michael
On 16 Feb 2022, at 17:24, Peter Müller peter.mueller@ipfire.org wrote:
There is no sense in instructing "trap" to catch signals it cannot trap whatsoever.
Signed-off-by: Peter Müller peter.mueller@ipfire.org
make.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/make.sh b/make.sh index 4dd068e4b..c06b4ec38 100755 --- a/make.sh +++ b/make.sh @@ -437,7 +437,7 @@ prepareenv() { fi
# Trap on emergency exit
- trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT
trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
# Checking if running as root user if [ $(id -u) -ne 0 ]; then
-- 2.34.1
Hello Michael,
rather cosmetic. shellcheck complains about this, and I was wondering why a SIGSTOP'ed build caused my workstation to malfunction until a reboot the other way.
The current "trap" command just arises false expectations... :-)
Thanks, and best regards, Peter Müller
Hello,
Is this a cosmetic change or does this fix a real world problem?
-Michael
On 16 Feb 2022, at 17:24, Peter Müller peter.mueller@ipfire.org wrote:
There is no sense in instructing "trap" to catch signals it cannot trap whatsoever.
Signed-off-by: Peter Müller peter.mueller@ipfire.org
make.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/make.sh b/make.sh index 4dd068e4b..c06b4ec38 100755 --- a/make.sh +++ b/make.sh @@ -437,7 +437,7 @@ prepareenv() { fi
# Trap on emergency exit
- trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT
trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
# Checking if running as root user if [ $(id -u) -ne 0 ]; then
-- 2.34.1
Okay. Thank you for the explanation.
Reviewed-by: Michael Tremer michael.tremer@ipfire.org
On 16 Feb 2022, at 17:27, Peter Müller peter.mueller@ipfire.org wrote:
Hello Michael,
rather cosmetic. shellcheck complains about this, and I was wondering why a SIGSTOP'ed build caused my workstation to malfunction until a reboot the other way.
The current "trap" command just arises false expectations... :-)
Thanks, and best regards, Peter Müller
Hello,
Is this a cosmetic change or does this fix a real world problem?
-Michael
On 16 Feb 2022, at 17:24, Peter Müller peter.mueller@ipfire.org wrote:
There is no sense in instructing "trap" to catch signals it cannot trap whatsoever.
Signed-off-by: Peter Müller peter.mueller@ipfire.org
make.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/make.sh b/make.sh index 4dd068e4b..c06b4ec38 100755 --- a/make.sh +++ b/make.sh @@ -437,7 +437,7 @@ prepareenv() { fi
# Trap on emergency exit
- trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGKILL SIGSTOP SIGQUIT
trap "exiterror 'Build process interrupted'" SIGINT SIGTERM SIGQUIT
# Checking if running as root user if [ $(id -u) -ne 0 ]; then
-- 2.34.1
-
Michael Tremer -
Peter Müller