HI,

On 09.03.2019 20:48, Bernhard Bitsch wrote:

...

Gesendet: Samstag, 09. März 2019 um 18:54 Uhr Von: "Matthias Fischer" matthias.fischer@ipfire.org An: "IPFire: Development-List" development@lists.ipfire.org Betreff: GUI for WLanAP doesn't reflect current settings for 'noscan' option

Hi,

could someone please take a look at:

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=d823d5f07211e984489027d5...

Especially (line 423): https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/wlanap.cgi;h=...

The WLanAP-GUI always shows the radio button as checked to ON, no matter what I choose.

Can anyone confirm?

Cannot confirm this. The WUI just shows the last saved stated as checked. Switch to off / save --> off is checked Switch to on / save --> on is checked

Best, Bernhard

Thanks for the feedback, but that is strange.

To get it working as expected, I had to change line 423 from:

<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}:&nbsp;</td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

To:

<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}:&nbsp;</td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

Don't know if I'm just puzzled, but whatever I did, ON remained checked.

Will take a closer look again.

Best, Matthias

Hi Matthias,

Gesendet: Samstag, 09. März 2019 um 21:59 Uhr Von: "Matthias Fischer" matthias.fischer@ipfire.org An: "Bernhard Bitsch" Bernhard.Bitsch@gmx.de, "IPFire Development" development@lists.ipfire.org Betreff: Re: Aw: GUI for WLanAP doesn't reflect current settings for 'noscan' option

Hi Bernhard,

On 09.03.2019 21:15, Matthias Fischer wrote:

...

...

...

...

Can anyone confirm?

Cannot confirm this. The WUI just shows the last saved stated as checked. Switch to off / save --> off is checked Switch to on / save --> on is checked

Hm.

Could you please check the resulting values for ON and OFF settings?

Here:

wlanap.cgi - ON is checked: /var/ipfire/wlanap/hostapd.conf => noscan=1 /var/ipfire/wlanap/settings => NOSCAN=on

wlanap.cgi - OFF is checked: /var/ipfire/wlanap/hostapd.conf => noscan=0 /var/ipfire/wlanap/settings => NOSCAN=OFF

Do you get the same results?

Best, Matthias

No, it's just the other way. Just as the original line reads, I think. I also checked the functionality. If I check "Neighbourhood scan=off" hostapd generates a 40MHZ signal, and vice versa. The semantics are ok also: "Neighbour scan=off" --> scan --> noscan=0.

Best, Bernhard

...

...

Best, Bernhard

Thanks for the feedback, but that is strange.

To get it working as expected, I had to change line 423 from:

<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> | <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

To:

<tr><td width='25%' class='base'>$Lang::tr{'wlanap neighbor scan'}: </td><td class='base' >on <input type='radio' name='NOSCAN' value='on' $checked{'NOSCAN'}{'on'} /> | <input type='radio' name='NOSCAN' value='off' $checked{'NOSCAN'}{'off'} /> off</td><td class='base' colspan='2'>$Lang::tr{'wlanap neighbor scan warning'}</td></tr>

Don't know if I'm just puzzled, but whatever I did, ON remained checked.

Will take a closer look again.

Best, Matthias