- When dealing with a problem on the forum I noticed that in the Fixed Leases table Legend section there was a very large space between the empty checkbox icon and the explanatory text. It looks like the   that I have removed worked on the text section 'click to enable' as that was moved but not on the off.gif icon as that stayed in its original place leaving a very large space between the icon and the explanatory text. Removing the two commands fixes that. - Reading up about   the problem might be related to these tags no longer being recommended to use with the newer HTML versions and that indenting or spacing should be done via CSS code. Will have a look in future on how to accomplish this via CSS.
Tested-by: Adolf Belka adolf.belka@ipfire.org Signed-off-by: Adolf Belka adolf.belka@ipfire.org --- html/cgi-bin/dhcp.cgi | 1 - 1 file changed, 1 deletion(-) mode change 100755 => 100644 html/cgi-bin/dhcp.cgi
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi old mode 100755 new mode 100644 index 84e2322af..ec5d62657 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1153,7 +1153,6 @@ print <<END <td class='boldbase'> <b>$Lang::tr{'legend'}: </b></td> <td><img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td> <td class='base'>$Lang::tr{'click to disable'}</td> - <td> </td> <td><img src='/images/off.gif' alt='$Lang::tr{'click to enable'}' /></td> <td class='base'>$Lang::tr{'click to enable'}</td> <td> </td>
- A new IPFire user on the forum saw the orange and red coloured blocks in the legend section and believed that they were messages about problems that had been created with the fixed leases. - This change puts a small block with seperate explanatory text for both the orange and red coloured blocks. - This change will also be applied to the wiki in a much clearer way
Tested-by: Adolf Belka adolf.belka@ipfire.org Signed-off-by: Adolf Belka adolf.belka@ipfire.org --- html/cgi-bin/dhcp.cgi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index ec5d62657..c079fe1ae 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1164,10 +1164,10 @@ print <<END </tr> <tr> <td> </td> - <td> </td> - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> - <td>  </td> - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> + <td class='base orange'> </td> + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> + <td class='base red'> </td> + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> <td> </td> <td> </td> $dup
Appreciated-by: Jon Murphy jon.murphy@ipfire.org
New tag in appreciation of the effort!
Happy New Year!
On Jan 1, 2024, at 8:35 AM, Adolf Belka adolf.belka@ipfire.org wrote:
- A new IPFire user on the forum saw the orange and red coloured blocks in the legend section and believed that they were messages about problems that had been created with the fixed leases.
- This change puts a small block with seperate explanatory text for both the orange and red coloured blocks.
- This change will also be applied to the wiki in a much clearer way
Tested-by: Adolf Belka adolf.belka@ipfire.org Signed-off-by: Adolf Belka adolf.belka@ipfire.org
html/cgi-bin/dhcp.cgi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index ec5d62657..c079fe1ae 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1164,10 +1164,10 @@ print <<END
</tr> <tr> <td> </td> - <td> </td> - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> - <td>  </td> - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> + <td class='base orange'> </td> + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> + <td class='base red'> </td> + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> <td> </td> <td> </td> $dup -- 2.43.0
Reviewed-by: Bernhard Bitsch bbitsch@ipfire.org
Am 01.01.2024 um 15:35 schrieb Adolf Belka:
- A new IPFire user on the forum saw the orange and red coloured blocks in the legend section and believed that they were messages about problems that had been created with the fixed leases.
- This change puts a small block with seperate explanatory text for both the orange and red coloured blocks.
- This change will also be applied to the wiki in a much clearer way
Tested-by: Adolf Belka adolf.belka@ipfire.org Signed-off-by: Adolf Belka adolf.belka@ipfire.org
html/cgi-bin/dhcp.cgi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index ec5d62657..c079fe1ae 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1164,10 +1164,10 @@ print <<END
</tr> <tr> <td> </td> - <td> </td> - <td class='base orange'>$Lang::tr{'ip address outside subnets'}</td> - <td>  </td> - <td class='base red'>$Lang::tr{'dhcp fixed ip address in dynamic range'}</td> + <td class='base orange'> </td> + <td class='base'> $Lang::tr{'ip address outside subnets'} </td> + <td class='base red'> </td> + <td class='base'> $Lang::tr{'dhcp fixed ip address in dynamic range'}</td> <td> </td> <td> </td> $dup
Reviewed-by: Bernhard Bitsch bbitsch@ipfire.org
Am 01.01.2024 um 15:35 schrieb Adolf Belka:
- When dealing with a problem on the forum I noticed that in the Fixed Leases table Legend section there was a very large space between the empty checkbox icon and the explanatory text. It looks like the   that I have removed worked on the text section 'click to enable' as that was moved but not on the off.gif icon as that stayed in its original place leaving a very large space between the icon and the explanatory text. Removing the two commands fixes that.
- Reading up about   the problem might be related to these tags no longer being recommended to use with the newer HTML versions and that indenting or spacing should be done via CSS code. Will have a look in future on how to accomplish this via CSS.
Tested-by: Adolf Belka adolf.belka@ipfire.org Signed-off-by: Adolf Belka adolf.belka@ipfire.org
html/cgi-bin/dhcp.cgi | 1 - 1 file changed, 1 deletion(-) mode change 100755 => 100644 html/cgi-bin/dhcp.cgi
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi old mode 100755 new mode 100644 index 84e2322af..ec5d62657 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -1153,7 +1153,6 @@ print <<END
<td class='boldbase'> <b>$Lang::tr{'legend'}: </b></td> <td><img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td> <td class='base'>$Lang::tr{'click to disable'}</td> - <td> </td> <td><img src='/images/off.gif' alt='$Lang::tr{'click to enable'}' /></td> <td class='base'>$Lang::tr{'click to enable'}</td> <td> </td>
-
Adolf Belka -
Bernhard Bitsch -
jon