Hello,

On 27 Dec 2020, at 16:48, Matthias Fischer matthias.fischer@ipfire.org wrote:

The 'WLanAP'-GUI is the only page where settings are saved by clicking an unlabeled floppy disk image.

Why? I don't know - this image is otherwise only used by the 'Backup'-GUI to save settings.

Now replaced by the standard 'Save' button.

Signed-off-by: Matthias Fischer matthias.fischer@ipfire.org

html/cgi-bin/wlanap.cgi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/html/cgi-bin/wlanap.cgi b/html/cgi-bin/wlanap.cgi index fd7e9a679..cfdcac576 100644 --- a/html/cgi-bin/wlanap.cgi +++ b/html/cgi-bin/wlanap.cgi @@ -516,8 +516,7 @@ print <<END

<table width='80%' cellspacing='0'> <tr><td align='center'> <form method='post' action='$ENV{'SCRIPT_NAME'}'> - <input type='hidden' name='ACTION' value=$Lang::tr{'save'} /> - <input type='image' alt='$Lang::tr{'save'}' title='$Lang::tr{'save'}' src='/images/media-floppy.png' /></form></td> + <input type='submit' name='ACTION' value=$Lang::tr{'save'} /></form></td>

This is invalid syntax because “value” is not quoted. Some HTML parsers do not care, but this would break if “save” would be longer than one word in one language.

-Michael

</tr> </table> END -- 2.18.0