Hi,
this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
What are these repetitions good for?
I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal).
You know: here I'll find ... graphs. Ok. Lets see.
But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
My two cents: I think we don't need this translation string at these specific points in the WUI.
Opinions?
Best, Matthias
Hi,
On 13 May 2020, at 09:38, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
What are these repetitions good for?
I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal).
You know: here I'll find ... graphs. Ok. Lets see.
But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
Yeah, we absolutely do not need that word in the headline.
“Memory” should make it clear what we are showing. It is obvious that the graph is a graph.
My two cents: I think we don't need this translation string at these specific points in the WUI.
Would you like to send in a patch for this?
Best, -Michael
Opinions?
Best, Matthias
Done.
And something more...
On 13.05.2020 11:59, Michael Tremer wrote:
Hi,
On 13 May 2020, at 09:38, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
What are these repetitions good for?
I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal).
You know: here I'll find ... graphs. Ok. Lets see.
But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
Yeah, we absolutely do not need that word in the headline.
“Memory” should make it clear what we are showing. It is obvious that the graph is a graph.
My two cents: I think we don't need this translation string at these specific points in the WUI.
Would you like to send in a patch for this?
Best, -Michael
Opinions?
Best, Matthias
Yay! As a lowly user, I mentioned this a few years ago but I figured my comment just went into the bit bucket. I'm glad I'm not the only one to see those "Duh!"s all over the place :-D
On 5/13/20 2:59 AM, Michael Tremer wrote:
Hi,
On 13 May 2020, at 09:38, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
What are these repetitions good for?
I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal).
You know: here I'll find ... graphs. Ok. Lets see.
But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
Yeah, we absolutely do not need that word in the headline.
“Memory” should make it clear what we are showing. It is obvious that the graph is a graph.
My two cents: I think we don't need this translation string at these specific points in the WUI.
Would you like to send in a patch for this?
Best, -Michael
Opinions?
Best, Matthias
Hi David,
Sorry to hear that your comment was lost somewhere.
But we like patches, so maybe send those :)
-Michael
On 24 May 2020, at 21:50, David Allen codermotor@gmail.com wrote:
Yay! As a lowly user, I mentioned this a few years ago but I figured my comment just went into the bit bucket. I'm glad I'm not the only one to see those "Duh!"s all over the place :-D
On 5/13/20 2:59 AM, Michael Tremer wrote:
Hi,
On 13 May 2020, at 09:38, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
this just came to my view while looking at Peters patches for 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
Searching for the translation string ...$Lang::tr{'graph'}... I found it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
What are these repetitions good for?
I mean, you click on "Network (external)". You read the topic "Net-Traffic graphs (external)" or "... (internal).
You know: here I'll find ... graphs. Ok. Lets see.
But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
Yeah, we absolutely do not need that word in the headline. “Memory” should make it clear what we are showing. It is obvious that the graph is a graph.
My two cents: I think we don't need this translation string at these specific points in the WUI.
Would you like to send in a patch for this? Best, -Michael
Opinions?
Best, Matthias
-
David Allen -
Matthias Fischer -
Michael Tremer