Hi,
this is the merge request to clean up the handling of initscripts in the build process of ipfire 2.
Please pull from git://git.ipfire.org/people/jschlag/ipfire-2.x.git initscripts-cleanup
to get these changes: - a new macro to install initscripts for packages ($(call INSTALL_INITSCRIPT,*name of the initscript*)) - the initscripts for packages are now stored in /src/initscripts/packages - the initscript for the system are stored in /src/initscripts/system - the rootfile of the the initscript lfs file contain now only the initscripts for the system, the initscript for each package are located in the rootfile of the package
This makes maintainering of the initscript in IPFire a lot easier, because the initscripts for teh system and for the packages are better seperated. The new macro makes the lfs files a little bit more cleaner.
Thanks in advance,
Jonatan
Hey Jonatan,
thanks for working on this. This is well needed since installing initscripts always was very messy and often caused lots of pain.
Before I merge this I would like to know if any of this needs to be shipped with the next core update or if everything should be the same after applying the patches - we would just have cleaner code then, obviously.
Thanks for not sending this is a patchset of >50 patches. :D
Best, -Michael
On Tue, 2017-03-07 at 14:45 +0100, Jonatan Schlag wrote:
Hi,
this is the merge request to clean up the handling of initscripts in the build process of ipfire 2.
Please pull from git://git.ipfire.org/people/jschlag/ipfire-2.x.git initscripts-cleanup
to get these changes:
- a new macro to install initscripts for packages
($(call INSTALL_INITSCRIPT,*name of the initscript*))
- the initscripts for packages are now stored in
/src/initscripts/packages
- the initscript for the system are stored in
/src/initscripts/system
- the rootfile of the the initscript lfs file contain now only the
initscripts for the system, the initscript for each package are located in the rootfile of the package
This makes maintainering of the initscript in IPFire a lot easier, because the initscripts for teh system and for the packages are better seperated. The new macro makes the lfs files a little bit more cleaner.
Thanks in advance,
Jonatan
Hi Michael
Am Mi, 8. Mär, 2017 um 1:21 schrieb Michael Tremer michael.tremer@ipfire.org:
Hey Jonatan,
thanks for working on this. This is well needed since installing initscripts always was very messy and often caused lots of pain.
Before I merge this I would like to know if any of this needs to be shipped with the next core update or if everything should be the same after applying the patches - we would just have cleaner code then, obviously.
From my point of nothing needs to be shipped with the next core update. We just change the way the build process is running. The content of the initscript are not changed nor which files will be shipped. Everything should be the same.
Regards Jonatan
Thanks for not sending this is a patchset of >50 patches. :D
Best, -Michael
On Tue, 2017-03-07 at 14:45 +0100, Jonatan Schlag wrote:
Hi,
this is the merge request to clean up the handling of initscripts in the build process of ipfire 2.
Please pull from git://git.ipfire.org/people/jschlag/ipfire-2.x.git initscripts-cleanup
to get these changes:
- a new macro to install initscripts for packages
($(call INSTALL_INITSCRIPT,*name of the initscript*))
- the initscripts for packages are now stored in
/src/initscripts/packages
- the initscript for the system are stored in
/src/initscripts/system
- the rootfile of the the initscript lfs file contain now only the
initscripts for the system, the initscript for each package are located in the rootfile of the package
This makes maintainering of the initscript in IPFire a lot easier, because the initscripts for teh system and for the packages are better seperated. The new macro makes the lfs files a little bit more cleaner.
Thanks in advance,
Jonatan
Thank you.
Merged.
-Michael
On Wed, 2017-03-08 at 16:04 +0100, Jonatan Schlag wrote:
Hi Michael
Am Mi, 8. Mär, 2017 um 1:21 schrieb Michael Tremer michael.tremer@ipfire.org:
Hey Jonatan,
thanks for working on this. This is well needed since installing initscripts always was very messy and often caused lots of pain.
Before I merge this I would like to know if any of this needs to be shipped with the next core update or if everything should be the same after applying the patches - we would just have cleaner code then, obviously.
From my point of nothing needs to be shipped with the next core update. We just change the way the build process is running. The content of the initscript are not changed nor which files will be shipped. Everything should be the same.
Regards Jonatan
Thanks for not sending this is a patchset of >50 patches. :D
Best, -Michael
On Tue, 2017-03-07 at 14:45 +0100, Jonatan Schlag wrote:
Hi,
this is the merge request to clean up the handling of initscripts in the build process of ipfire 2.
Please pull from git://git.ipfire.org/people/jschlag/ipfire-2.x.git initscripts-cleanup
to get these changes: - a new macro to install initscripts for packages ($(call INSTALL_INITSCRIPT,*name of the initscript*)) - the initscripts for packages are now stored in /src/initscripts/packages - the initscript for the system are stored in /src/initscripts/system - the rootfile of the the initscript lfs file contain now only the initscripts for the system, the initscript for each package are located in the rootfile of the package
This makes maintainering of the initscript in IPFire a lot easier, because the initscripts for teh system and for the packages are better seperated. The new macro makes the lfs files a little bit more cleaner.
Thanks in advance,
Jonatan