Hi,
so in recent times we had many people who have struggled with sending in patches. The topic comes up every few weeks and I am not aware why that is. I find this process with "git send-email" very easy and I am not sure where the problems could be.
So I would like to start a discussion about where the problems are and maybe that some of you can share their experiences and solutions. What tools are you using? Do they need special settings?
The goal of that should be that we can add all the required information to the documentation. Sending in patches should not be this frustration experience it is at the moment.
http://wiki.ipfire.org/devel/submit-patches
Best, -Michael
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO). Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository. Discussion can take place with that merge request.
In case you are open to using other tools in place of Patchwork, what about Gitlab?
Lars
Hi,
so about half a week has passed since my initial email. I suppose this is all that is coming and that the others are perfectly satisfied with this process.
So let's conclude:
On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO).
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository.
We can't use GitHub. I have explained that at various occasions and this thread wasn't started to discuss other tools. Other things have been proposed, too, and the same goes for them.
At the end the only problem I understand you are experiencing here is actually emailing the patch files without your mail agents not making garbage out of that. This can't be too hard to get right.
Discussion can take place with that merge request.
No, not at all. This process is actually well thought through and designed to maximise participation of the users and make everything easy for developers. And I actually think it does that well.
In case you are open to using other tools in place of Patchwork, what
about Gitlab?
Patchwork is just a view to the patches. My actual repository for that is my inbox.
Lars
-Michael
Hello Michael,
Michael Tremer:
Hi,
so about half a week has passed since my initial email. I suppose this is all that is coming and that the others are perfectly satisfied with this process.
So let's conclude:
On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO).
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
I recently wrote a page about sending in patches via a Mail User Agent. It can be found here: https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias Fischer here who sent me a good hint about disabling line-wrapping in TB.)
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository.
We can't use GitHub. I have explained that at various occasions and this thread wasn't started to discuss other tools. Other things have been proposed, too, and the same goes for them.
At the end the only problem I understand you are experiencing here is actually emailing the patch files without your mail agents not making garbage out of that. This can't be too hard to get right.
Discussion can take place with that merge request.
No, not at all. This process is actually well thought through and designed to maximise participation of the users and make everything easy for developers. And I actually think it does that well.
For me, sending in patches is not a very big issue since you only need to "set up" a system for sending in patches once.
The problem is more the workflow after a patch has been sent in. Some of them seem to be dropped silently, while others are commented and then somehow forgotten. Perhaps I need to polish my english skills in order to add better descriptions to my patches... ;-)
In case you are open to using other tools in place of Patchwork, what
about Gitlab?
Patchwork is just a view to the patches. My actual repository for that is my inbox.
Lars
-Michael
Best regards, Timmothy Wilson
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I understand that some people may need or want Windows as their base machine and have little reason for having a separate Unix (Linux) machine. Yet, in some cases, having access to such a machine for development purposes could be useful.
I run a series of servers at a NOC here in the US. If anyone is interested, I'd be happy to build out a Linux or FreeBSD virtual for this purpose. I could be a pure Command Line machine (what I normally run) or I could put a very basic GUI (XFCE4) on it. You could choose to access it via OpenVPN (much more secure) or direct public IP.
If anyone wants to try it, let me know. This is totally no pressure, you can try the system, and if the environment is too alien for you to really get work done, then just bail out. But I'd be happy to set it up for one or more developers to use.
Feel free to respond on list, or write me directly.
Rod
On 01/15/2016 02:07 AM, IT Superhack wrote:
Hello Michael,
Michael Tremer:
Hi,
so about half a week has passed since my initial email. I suppose this is all that is coming and that the others are perfectly satisfied with this process.
So let's conclude:
On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO).
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
I recently wrote a page about sending in patches via a Mail User Agent. It can be found here: https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias Fischer here who sent me a good hint about disabling line-wrapping in TB.)
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository.
We can't use GitHub. I have explained that at various occasions and this thread wasn't started to discuss other tools. Other things have been proposed, too, and the same goes for them.
At the end the only problem I understand you are experiencing here is actually emailing the patch files without your mail agents not making garbage out of that. This can't be too hard to get right.
Discussion can take place with that merge request.
No, not at all. This process is actually well thought through and designed to maximise participation of the users and make everything easy for developers. And I actually think it does that well.
For me, sending in patches is not a very big issue since you only need to "set up" a system for sending in patches once.
The problem is more the workflow after a patch has been sent in. Some of them seem to be dropped silently, while others are commented and then somehow forgotten. Perhaps I need to polish my english skills in order to add better descriptions to my patches... ;-)
In case you are open to using other tools in place of Patchwork, what
about Gitlab?
Patchwork is just a view to the patches. My actual repository for that is my inbox.
Lars
-Michael
Best regards, Timmothy Wilson
- -- Rod Rodolico Daily Data, Inc. POB 140465 Dallas TX 75214-0465 214.827.2170 http://www.dailydata.net
Hey Rod,
this is a great offer. Thank you very much. I hope that someone will find this useful.
On Fri, 2016-01-15 at 13:24 -0600, R. W. Rodolico wrote:
I understand that some people may need or want Windows as their base machine and have little reason for having a separate Unix (Linux) machine. Yet, in some cases, having access to such a machine for development purposes could be useful.
I run a series of servers at a NOC here in the US. If anyone is interested, I'd be happy to build out a Linux or FreeBSD virtual for this purpose. I could be a pure Command Line machine (what I normally run) or I could put a very basic GUI (XFCE4) on it. You could choose to access it via OpenVPN (much more secure) or direct public IP.
Just wanted to say quickly that it will have to be a Linux. I am not sure if is possible in any way to build IPFire on a BSD. Our build system doesn't support this right now and I doubt that this is possible at all. So use Linux please.
If anyone wants to try it, let me know. This is totally no pressure, you can try the system, and if the environment is too alien for you to really get work done, then just bail out. But I'd be happy to set it up for one or more developers to use.
Feel free to respond on list, or write me directly.
Rod
-Michael
On 01/15/2016 02:07 AM, IT Superhack wrote:
Hello Michael,
Michael Tremer:
Hi,
so about half a week has passed since my initial email. I suppose this is all that is coming and that the others are perfectly satisfied with this process.
So let's conclude:
On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO).
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
I recently wrote a page about sending in patches via a Mail User Agent. It can be found here: https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias Fischer here who sent me a good hint about disabling line-wrapping in TB.)
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository.
We can't use GitHub. I have explained that at various occasions and this thread wasn't started to discuss other tools. Other things have been proposed, too, and the same goes for them.
At the end the only problem I understand you are experiencing here is actually emailing the patch files without your mail agents not making garbage out of that. This can't be too hard to get right.
Discussion can take place with that merge request.
No, not at all. This process is actually well thought through and designed to maximise participation of the users and make everything easy for developers. And I actually think it does that well.
For me, sending in patches is not a very big issue since you only need to "set up" a system for sending in patches once.
The problem is more the workflow after a patch has been sent in. Some of them seem to be dropped silently, while others are commented and then somehow forgotten. Perhaps I need to polish my english skills in order to add better descriptions to my patches... ;-)
In case you are open to using other tools in place of Patchwork, what
about Gitlab?
Patchwork is just a view to the patches. My actual repository for that is my inbox.
Lars
-Michael
Best regards, Timmothy Wilson
Hi,
On 15.01.2016 20:24, R. W. Rodolico wrote:
I understand that some people may need or want Windows as their base machine and have little reason for having a separate Unix (Linux) machine. Yet, in some cases, having access to such a machine for development purposes could be useful.
Indeed...!
I run a series of servers at a NOC here in the US. If anyone is interested, I'd be happy to build out a Linux or FreeBSD virtual for this purpose. I could be a pure Command Line machine (what I normally run)...
As Michael already wrote: great idea, great offer: +1!
I'd recommend Linux too. I'm working here on an Ubuntu LTS system (command line). Pretty handy...
Best, Matthias
On Fri, 2016-01-15 at 09:07 +0100, IT Superhack wrote:
Hello Michael,
Michael Tremer:
Hi,
so about half a week has passed since my initial email. I suppose this is all that is coming and that the others are perfectly satisfied with this process.
So let's conclude:
On Mon, 2016-01-11 at 21:40 +0100, Larsen wrote:
On Sun, 10 Jan 2016 22:54:26 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I find this process with "git send-email" very easy and I am not sure where the problems could be.
I am using TortoiseGit with Windows 7. I don't know if this tool supports "git send-email" and I wouldn't want to use command line git (it is annoying to use more than one tool for the same job, IMHO).
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Therefore, I create a patch file using TortoiseGit (I need a workflow reminder for this to get it right), then send the contents with Thunderbird where I have to remember to disable line wrap (also using a workflow reminder text).
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
I recently wrote a page about sending in patches via a Mail User Agent. It can be found here: https://wiki.ipfire.org/devel/send-tb-patches (Thanks to Matthias Fischer here who sent me a good hint about disabling line-wrapping in TB.)
In other projects (using Github), IMHO it is much easier to push to one's own repository and create a merge request to the upstream repository.
We can't use GitHub. I have explained that at various occasions and this thread wasn't started to discuss other tools. Other things have been proposed, too, and the same goes for them.
At the end the only problem I understand you are experiencing here is actually emailing the patch files without your mail agents not making garbage out of that. This can't be too hard to get right.
Discussion can take place with that merge request.
No, not at all. This process is actually well thought through and designed to maximise participation of the users and make everything easy for developers. And I actually think it does that well.
For me, sending in patches is not a very big issue since you only need to "set up" a system for sending in patches once.
The problem is more the workflow after a patch has been sent in. Some of them seem to be dropped silently, while others are commented and then somehow forgotten. Perhaps I need to polish my english skills in order to add better descriptions to my patches... ;-)
That is a completely different matter though. You should find the emails then and ask why certain things are happening.
I tried to cover this a bit over here:
http://wiki.ipfire.org/devel/submit-patches#respond_to_review_comments
and here:
http://wiki.ipfire.org/devel/submit-patches#don_t_get_discouraged_-_or_impat...
In case you are open to using other tools in place of Patchwork, what
about Gitlab?
Patchwork is just a view to the patches. My actual repository for that is my inbox.
Lars
-Michael
Best regards, Timmothy Wilson
-Michael
On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Till now, I only wanted to improve things where I didn't need to build the distribution. Otherwise, I would probably have setup a Linux VM.
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
Ok, will see to get the stuff into the wiki. Into which article should I put it?
Lars
On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Till now, I only wanted to improve things where I didn't need to build the distribution. Otherwise, I would probably have setup a Linux VM.
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
Ok, will see to get the stuff into the wiki. Into which article should I put it?
Split the content in small and topical pages in the namespace where the other ones are already.
Best, -Michael
Lars
On Sun, 17 Jan 2016 20:17:22 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Till now, I only wanted to improve things where I didn't need to build the distribution. Otherwise, I would probably have setup a Linux VM.
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
Ok, will see to get the stuff into the wiki. Into which article should I put it?
Split the content in small and topical pages in the namespace where the other ones are already.
here it is: http://wiki.ipfire.org/devel/tortoisegit
Lars
Hi,
On Thu, 2016-01-28 at 18:36 +0100, Larsen wrote:
On Sun, 17 Jan 2016 20:17:22 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
On Sat, 2016-01-16 at 19:07 +0100, Larsen wrote:
On Fri, 15 Jan 2016 02:25:43 +0100, Michael Tremer michael.tremer@ipfire.org wrote:
I didn't know that this many people use Windows. The problem with that is you cannot build the distribution. You can copy some files back and forth, but never build.
I consider this to be a huge disadvantage.
Is this just by choice or did you not want to go through the trouble setting up a Linux system?
Till now, I only wanted to improve things where I didn't need to build the distribution. Otherwise, I would probably have setup a Linux VM.
When ever you make personal notes, why not use the wiki for that and share? Many other people might have the same questions.
Ok, will see to get the stuff into the wiki. Into which article should I put it?
Split the content in small and topical pages in the namespace where the other ones are already.
here it is: http://wiki.ipfire.org/devel/tortoisegit
Great. I moved this into the Git sub-section:
http://wiki.ipfire.org/devel/git/windows
I didn't test if this actually works because I do not use Windows.
Best, -Michael
Lars
Hi,
On 10.01.2016 22:54, Michael Tremer wrote:
I find this process with "git send-email" very easy...
Just a few "cents" from me... ;-)
I don't know how you would call it:
I'm doing it the "old-fashioned way": strictly by command-line, directly from GIT on my Ubuntu 'Devel'-PC. No GUI, no mouse, just console and keyboard. Nothing but blinking cursors and GIT commands. git pull ..., git status ..., nano or mc-editor, make ..., git push ..., git sendmail ...: thats nearly all I use and need.
And after struggling through some - sometimes rather weird - problems, I'm getting used to it and wouldn't want to do it any other way. Its logical and fast. Not comfortable, but 'at the roots'.
And while creating a patch for a new 'nano 2.5.1'-version (http://patchwork.ipfire.org/patch/208/) I got the thought that perhaps it would help others if I would ~record the process of creating this - rather easy - patch with some "how I did it" explanations and/or screenshots so they could get a grip on the procedure? Thinking of "Building Addons", perhaps we could put something like that in Wiki? Not too complicated, just showing how to build an rather easy patch and push it/send it through GIT.
Sorry, I got Windows 7 running, but none of the mentioned tools here, so my prerequisits may differ.
It would take some time, but I think, this could be a way to make things easier.
Jm2C
Best, Matthias
On Tue, 2016-01-12 at 19:08 +0100, Matthias Fischer wrote:
Hi,
On 10.01.2016 22:54, Michael Tremer wrote:
I find this process with "git send-email" very easy...
Just a few "cents" from me... ;-)
I don't know how you would call it:
I'm doing it the "old-fashioned way": strictly by command-line, directly from GIT on my Ubuntu 'Devel'-PC. No GUI, no mouse, just console and keyboard. Nothing but blinking cursors and GIT commands. git pull ..., git status ..., nano or mc-editor, make ..., git push ..., git sendmail ...: thats nearly all I use and need.
I never considered that anyone would use something else than the command line.
And after struggling through some - sometimes rather weird - problems, I'm getting used to it and wouldn't want to do it any other way. Its logical and fast. Not comfortable, but 'at the roots'.
Git is - of course like anything else - something that everyone needs to learn at the start. After that is indeed logical and fast.
And while creating a patch for a new 'nano 2.5.1'-version (http://patchwork.ipfire.org/patch/208/) I got the thought that perhaps it would help others if I would ~record the process of creating this
rather easy - patch with some "how I did it" explanations and/or screenshots so they could get a grip on the procedure? Thinking of "Building Addons", perhaps we could put something like that in Wiki? Not too complicated, just showing how to build an rather easy patch and push it/send it through GIT.
Maybe we should setup a page on the wiki to explain using git send -email. I thought people read man pages from time to time which makes this obsolete.
Sorry, I got Windows 7 running, but none of the mentioned tools here, so my prerequisits may differ.
It would take some time, but I think, this could be a way to make things easier.
Jm2C
Best, Matthias
-Michael
-
IT Superhack -
Larsen -
Matthias Fischer -
Michael Tremer -
R. W. Rodolico