Hello,

Could we drop the table borders, please?

We do not have them anywhere in the web UI. Instead we have alternating shades of grey. Can we have those instead?

Best, -Michael

On 22 May 2021, at 17:53, Jon Murphy jcmurphy26@gmail.com wrote:

I like it! "make it so"

Jon

...

On May 22, 2021, at 9:53 AM, Matthias Fischer matthias.fischer@ipfire.org wrote:

Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588

Hi,

in the meantime I worked on this - a bit - again. Currently, this CGI is running here under Core 156 with no seen problems.

I've made several changes and adjustments.

First:

• I kept the icons - buttons didn't look as I hoped they would. ;-)

• I kept the old icon order "Download - Delete - Save".

Changelog:

• Cleaned up the code a bit, some if-queries were unnessecary (if

($cgiparams{'ACTION'} eq...).

• Therefore, some lang strings became obsolete ('downloadaddon' and

'downloadiso'.

• Separated the ISO files from the IPF files for better overview.

• Added query for deleting a backup file (onclick="return confirm...).

• Added 'onclick' feature => deleting a file must be acknowledged.

Biggest change:

• Added tables - as MT mentioned.

Details can be seen in the attached screenshots.

Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

Best, Matthias

<2021-05-22_backup.cgi.png><2021-05-22_backup.cgi_onclick.png>

Hi Adolf,

On 26.05.2021 13:01, Adolf Belka wrote:

Hi Matthias,

On 22/05/2021 16:53, Matthias Fischer wrote:

...

Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588

Hi,

in the meantime I worked on this - a bit - again. Currently, this CGI is running here under Core 156 with no seen problems.

I've made several changes and adjustments.

First:

• I kept the icons - buttons didn't look as I hoped they would. ;-)

• I kept the old icon order "Download - Delete - Save".

Changelog:

• Cleaned up the code a bit, some if-queries were unnessecary (if

($cgiparams{'ACTION'} eq...).

• Therefore, some lang strings became obsolete ('downloadaddon' and

'downloadiso'.

• Separated the ISO files from the IPF files for better overview.

• Added query for deleting a backup file (onclick="return confirm...).

• Added 'onclick' feature => deleting a file must be acknowledged.

Biggest change:

• Added tables - as MT mentioned.

Details can be seen in the attached screenshots.

Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.

Nice. Thanks. But...

At the moment I have no idea how to change this CGI to show these alternating rows. I never did this. For a start I looked into some other CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services, wakeonlan, wio and log.dat). But alternate rows seem to be a bit more complicated to me than the tables. Hm. [I'm not an experienced programmer with CGI (call me "scriptkiddie" ;-) ).]

If everything fails, I'll have to ask for hints how to do this. I'll see how far I can get.

Any chance of a diff so I can try it out on a testbed system?

No problem. Work in progress...

By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320

I'm aware of this. Not much time these days... ;-)

Best, Matthias

Hi Matthias,

You can style the table with CSS, you don't have to change anything in the CGI for that. I did this e.g. in zoneconf.cgi with the "nth-child" selector and it works great: https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=html/cgi-bin/zoneconf.cgi;... (In a perfect world, the CSS would not be mixed into the CGI, but hopefully you see how it works)

Best Leo

Am 26.05.2021 um 17:32 schrieb Matthias Fischer:

Hi Adolf,

On 26.05.2021 13:01, Adolf Belka wrote:

...

Hi Matthias,

On 22/05/2021 16:53, Matthias Fischer wrote:

...

Still based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588

Hi,

in the meantime I worked on this - a bit - again. Currently, this CGI is running here under Core 156 with no seen problems.

I've made several changes and adjustments.

First:

• I kept the icons - buttons didn't look as I hoped they would. ;-)

• I kept the old icon order "Download - Delete - Save".

Changelog:

• Cleaned up the code a bit, some if-queries were unnessecary (if

($cgiparams{'ACTION'} eq...).

• Therefore, some lang strings became obsolete ('downloadaddon' and

'downloadiso'.

• Separated the ISO files from the IPF files for better overview.

• Added query for deleting a backup file (onclick="return confirm...).

• Added 'onclick' feature => deleting a file must be acknowledged.

Biggest change:

• Added tables - as MT mentioned.

Details can be seen in the attached screenshots.

Thoughts? Opinions? I'd like to get some feedback before pushing this... ;-)

It looks okay to me. Alternating shades of grey for the rows as mentioned by Michael would also be fine.

Nice. Thanks. But...

At the moment I have no idea how to change this CGI to show these alternating rows. I never did this. For a start I looked into some other CGIs to get a grip (e.g.: dns, firewall, fwhosts, hosts, services, wakeonlan, wio and log.dat). But alternate rows seem to be a bit more complicated to me than the tables. Hm. [I'm not an experienced programmer with CGI (call me "scriptkiddie" ;-) ).]

If everything fails, I'll have to ask for hints how to do this. I'll see how far I can get.

...

Any chance of a diff so I can try it out on a testbed system?

No problem. Work in progress...

...

By the way, FYI there is another backup umbrella bug https://bugzilla.ipfire.org/show_bug.cgi?id=11320

I'm aware of this. Not much time these days... ;-)

Best, Matthias