Link the IPFire logo and subsequent text to http://www.ipfire.org
Signed-off-by: Lars Schuhmacher larsen007@web.de --- html/html/themes/darkdos/include/functions.pl | 2 +- html/html/themes/ipfire-legacy/include/functions.pl | 2 +- html/html/themes/ipfire/include/functions.pl | 2 +- html/html/themes/maniac/include/functions.pl | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/html/themes/darkdos/include/functions.pl b/html/html/themes/darkdos/include/functions.pl index 737e051..4b00b4c 100644 --- a/html/html/themes/darkdos/include/functions.pl +++ b/html/html/themes/darkdos/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
- <div id="logo"> + <div id="logo" style="cursor: pointer;" onclick="window.location='http://www.ipfire.org/';"> END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') { diff --git a/html/html/themes/ipfire-legacy/include/functions.pl b/html/html/themes/ipfire-legacy/include/functions.pl index 1401030..e1b8cb8 100644 --- a/html/html/themes/ipfire-legacy/include/functions.pl +++ b/html/html/themes/ipfire-legacy/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
- <div id="logo"> + <div id="logo" style="cursor: pointer;" onclick="window.location='http://www.ipfire.org/';"> END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') { diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl index 63740d4..39d972d 100644 --- a/html/html/themes/ipfire/include/functions.pl +++ b/html/html/themes/ipfire/include/functions.pl @@ -151,7 +151,7 @@ print <<END </head> <body> <div id="header" class="fixed"> - <div id="logo"> + <div id="logo" style="cursor: pointer;" onclick="window.location='http://www.ipfire.org/';"> END ; if ($settings{'WINDOWWITHHOSTNAME'} ne 'off') { diff --git a/html/html/themes/maniac/include/functions.pl b/html/html/themes/maniac/include/functions.pl index e8514ad..d3d4a73 100644 --- a/html/html/themes/maniac/include/functions.pl +++ b/html/html/themes/maniac/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
- <div id="logo"> + <div id="logo" style="cursor: pointer;" onclick="window.location='http://www.ipfire.org/';"> END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
Hi Lars,
Is there a certain reason why this is done by using Javascript? An <a> tag would have worked fine as well I think. That would require to embed the image by using the <img> tag, but that is probably the cleaner solution any way...
Other than that: I like the idea.
Best, -Michael
On Mon, 2015-06-08 at 22:50 +0200, Larsen wrote:
Link the IPFire logo and subsequent text to http://www.ipfire.org
Signed-off-by: Lars Schuhmacher larsen007@web.de
html/html/themes/darkdos/include/functions.pl | 2 +- html/html/themes/ipfire-legacy/include/functions.pl | 2 +- html/html/themes/ipfire/include/functions.pl | 2 +- html/html/themes/maniac/include/functions.pl | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/html/themes/darkdos/include/functions.pl b/html/html/themes/darkdos/include/functions.pl index 737e051..4b00b4c 100644 --- a/html/html/themes/darkdos/include/functions.pl +++ b/html/html/themes/darkdos/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
<div id="logo">
<div id="logo" style="cursor: pointer;"onclick="window.location='http://www.ipfire.org/%27;%22%3E END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') { diff --git a/html/html/themes/ipfire-legacy/include/functions.pl b/html/html/themes/ipfire-legacy/include/functions.pl index 1401030..e1b8cb8 100644 --- a/html/html/themes/ipfire-legacy/include/functions.pl +++ b/html/html/themes/ipfire-legacy/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
<div id="logo">
<div id="logo" style="cursor: pointer;"onclick="window.location='http://www.ipfire.org/%27;%22%3E END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') { diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl index 63740d4..39d972d 100644 --- a/html/html/themes/ipfire/include/functions.pl +++ b/html/html/themes/ipfire/include/functions.pl @@ -151,7 +151,7 @@ print <<END
</head> <body> <div id="header" class="fixed"> - <div id="logo"> + <div id="logo" style="cursor: pointer;" onclick="window.location='http://www.ipfire.org/';"> END ; if ($settings{'WINDOWWITHHOSTNAME'} ne 'off') { diff --git a/html/html/themes/maniac/include/functions.pl b/html/html/themes/maniac/include/functions.pl index e8514ad..d3d4a73 100644 --- a/html/html/themes/maniac/include/functions.pl +++ b/html/html/themes/maniac/include/functions.pl @@ -221,7 +221,7 @@ print <<END
<div id="header_inner" class="fixed">
<div id="logo">
<div id="logo" style="cursor: pointer;"onclick="window.location='http://www.ipfire.org/%27;%22%3E END ; if ($settings{'WINDOWWITHHOSTNAME'} eq 'on') {
On Tue, 09 Jun 2015 12:53:08 +0200, Michael Tremer michael.tremer@ipfire.org wrote:
Is there a certain reason why this is done by using Javascript? An <a> tag would have worked fine as well I think. That would require to embed the image by using the <img> tag, but that is probably the cleaner solution any way...
I used this as a starting point: http://stackoverflow.com/questions/4465923/a-href-link-for-entire-div-in-htm...
The <a>-tag didn´t work when I wrapped it around the <div>-tag (and it would only be allowed for HTML5). I didn´t think about using an <img>-tag as I thought that it was cleaner as it is by using CSS.
I do know that some have JS deactivated and don´t like it, but in this case there is nothing lost. Is there anything else wrong with using JS?
Lars
On Tue, 2015-06-09 at 12:59 +0200, Larsen wrote:
On Tue, 09 Jun 2015 12:53:08 +0200, Michael Tremer michael.tremer@ipfire.org wrote:
Is there a certain reason why this is done by using Javascript? An <a> tag would have worked fine as well I think. That would require to embed the image by using the <img> tag, but that is probably the cleaner solution any way...
I used this as a starting point: http://stackoverflow.com/questions/4465923/a-href-link-for-entire-div-in-htm...
The <a>-tag didn´t work when I wrapped it around the <div>-tag (and it would only be allowed for HTML5). I didn´t think about using an <img>-tag as I thought that it was cleaner as it is by using CSS.
I do know that some have JS deactivated and don´t like it, but in this case there is nothing lost.
If someone disables JS they will already have issues with other parts of the web user interface and of course most of the "web 2.0".
Is there anything else wrong with using JS?
Not in general. I just find it a rather complex solution for a simple problem. The plain HTML approach would be much better and work for those who disable JS, too.
-Michael
Lars
On Tue, 09 Jun 2015 13:02:15 +0200, Michael Tremer michael.tremer@ipfire.org wrote:
I do know that some have JS deactivated and don´t like it, but in this case there is nothing lost.
If someone disables JS they will already have issues with other parts of the web user interface and of course most of the "web 2.0".
Is there anything else wrong with using JS?
Not in general. I just find it a rather complex solution for a simple problem. The plain HTML approach would be much better and work for those who disable JS, too.
But then you loose CSS, don´t you? And if someone has actually disabled JS, they will notice other problems as you mentioned before, so it´s unlikely they will even noticed that they cannot click on the IPFire logo to get to the homepage.
Lars
On Tue, 2015-06-09 at 13:13 +0200, Larsen wrote:
On Tue, 09 Jun 2015 13:02:15 +0200, Michael Tremer michael.tremer@ipfire.org wrote:
I do know that some have JS deactivated and don´t like it, but in this case there is nothing lost.
If someone disables JS they will already have issues with other parts of the web user interface and of course most of the "web 2.0".
Is there anything else wrong with using JS?
Not in general. I just find it a rather complex solution for a simple problem. The plain HTML approach would be much better and work for those who disable JS, too.
But then you loose CSS, don´t you?
What do you mean by loose? That should be changed then, yes.
The final HTML code would look something like this:
<div id="logo"> <a href="http://www.ipfire.org"> <img src="logo.png" ...> </a> </div>
The CSS properties should be changed that the background image is removed and the content is centered. The final result should like the same in the end.
And if someone has actually disabled JS, they will notice other problems as you mentioned before, so it´s unlikely they will even noticed that they cannot click on the IPFire logo to get to the homepage.
Lars
The final HTML code would look something like this:
<div id="logo"> <a href="http://www.ipfire.org"> <img src="logo.png" ...> </a> </div>
The CSS properties should be changed that the background image is removed and the content is centered. The final result should like the same in the end.
Ok, will try this and report back later.
Lars
-
Larsen -
Michael Tremer