Location February 2021

location@lists.ipfire.org

2 participants
5 discussions

[PATCH] Makefile.am: Honor DESTDIR when installing perl bindings
by Stefan Schantl 27 Feb '21

27 Feb '21

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 4b865f1..65e96d7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -239,7 +239,7 @@ check-perl: testdata.db .PHONY: install-perl install-perl: - cd $(builddir)/src/perl && $(MAKE) install + cd $(builddir)/src/perl && $(MAKE) install DESTIDR=$(DESTDIR) .PHONY: clean-perl clean-perl: -- 2.20.1

1 0

[PATCH] Makefile.am: Do not specify CC and LD when building perl module.
by Stefan Schantl 23 Feb '21

23 Feb '21

Specifing the CC and LD flags is not required because perl MakeMaker takes care of this. Fixes #12574. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 52a4722..8da1f1b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -230,7 +230,7 @@ build-perl: cd $(builddir)/src/perl && $(PERL) Makefile.PL INSTALLDIRS=vendor \ INC="-I$(abs_srcdir)/src" LIBS="-L$(abs_builddir)/src/.libs -lloc" - cd $(builddir)/src/perl && $(MAKE) CC="$(CC)" LD="$(LD)" LD_RUN_PATH= + cd $(builddir)/src/perl && $(MAKE) LD_RUN_PATH="" .PHONY: check-perl check-perl: testdata.db -- 2.20.1

1 0

[PATCH] Makefile.am: Do not provide PREFIX value for perl build.
by Stefan Schantl 22 Feb '21

22 Feb '21

This caused to gain the following error when building: Only one of PREFIX or INSTALL_BASE can be given. Not both. Using INSTALLDIRS=vendor is the common way to get the modules installed into the right directories. Fixes #12573. Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index dc594f8..52a4722 100644 --- a/Makefile.am +++ b/Makefile.am @@ -228,7 +228,7 @@ build-perl: @test -e $(builddir)/src/perl/t/Location.t || ln -s --relative $(srcdir)/src/perl/t/Location.t $(builddir)/src/perl/t/ @test -e $(builddir)/src/perl/typemap || ln -s --relative $(srcdir)/src/perl/typemap $(builddir)/src/perl/ - cd $(builddir)/src/perl && $(PERL) Makefile.PL PREFIX="$(prefix)" \ + cd $(builddir)/src/perl && $(PERL) Makefile.PL INSTALLDIRS=vendor \ INC="-I$(abs_srcdir)/src" LIBS="-L$(abs_builddir)/src/.libs -lloc" cd $(builddir)/src/perl && $(MAKE) CC="$(CC)" LD="$(LD)" LD_RUN_PATH= -- 2.20.1

1 0

[PATCH] override-{a1,other}: weekly batch of overrides
by Peter Müller 09 Feb '21

09 Feb '21

Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org> --- overrides/override-a1.txt | 26 ++++++++++++++++++++++++++ overrides/override-other.txt | 10 ++++++++++ 2 files changed, 36 insertions(+) diff --git a/overrides/override-a1.txt b/overrides/override-a1.txt index 3dc43fd..a7594bf 100644 --- a/overrides/override-a1.txt +++ b/overrides/override-a1.txt @@ -166,6 +166,17 @@ descr: Privex Inc. remarks: VPN and Tor relay provider is-anonymous-proxy: yes +aut-num: AS212052 +descr: BOET NOTIFY LTD. +remarks: VPN provider [high confidence, but not proofed] +is-anonymous-proxy: yes + +aut-num: AS212786 +descr: Pooky L&W SDN BHD +remarks: VPN provider [high confidence, but not proofed] +is-anonymous-proxy: yes +country: GB + aut-num: AS212987 descr: NekoCloud Solutions Limited remarks: VPN provider [high confidence, but not proofed] @@ -246,6 +257,16 @@ descr: Privax LTD / PRCDN Consumer Pool / AVAST s.r.o. remarks: VPN provider is-anonymous-proxy: yes +net: 5.182.34.0/24 +descr: Coca Proxies VOF +remarks: VPN provider +is-anonymous-proxy: yes + +net: 5.182.35.0/24 +descr: Coca Proxies VOF +remarks: VPN provider +is-anonymous-proxy: yes + net: 5.249.160.0/24 descr: VPNTunnel remarks: VPN provider @@ -1213,6 +1234,11 @@ descr: PureVPN remarks: VPN provider is-anonymous-proxy: yes +net: 193.42.136.0/24 +descr: IntelligenceHosting +remarks: VPN provider [high confidence, but not proofed] +is-anonymous-proxy: yes + net: 193.150.8.0/22 descr: GZ Systems Limited / PureVPN remarks: VPN provider diff --git a/overrides/override-other.txt b/overrides/override-other.txt index 30ac0db..b34f055 100644 --- a/overrides/override-other.txt +++ b/overrides/override-other.txt @@ -53,6 +53,11 @@ descr: Yes Networks Unlimited Ltd remarks: traces to UA, but some RIR entries seem to contain garbage (VG) country: UA +aut-num: AS25098 +descr: Netcalibre Ltd. +remarks: ISP located in GB, but some RIR data for announced prefixes contain garbage/ +country: GB + aut-num: AS28098 descr: ABGON Comunicaciones remarks: ISP located in CL, but some RIR data for announced prefixes contain garbage (BZ) @@ -283,6 +288,11 @@ descr: Gudaev Maxim Amrakhovich remarks: announcements scatter across various places in EU (DE/CZ/??), but RIR data contain garbage country: EU +aut-num: AS213035 +descr: Serverion BV +remarks: ISP located in NL, but RIR data for most announced prefixes contain garbage +country: NL + aut-num: AS213058 descr: Private Internet Hosting LTD remarks: bulletproof ISP located in RU -- 2.26.2

1 0

[PATCH] location-importer.in: skip networks with unknown country codes
by Peter Müller 04 Feb '21

04 Feb '21

There is no sense in parsing and storting networks whose country codes cannot be found in the ISO-3166-x country code table. This avoids side effects in applications using the location database, and introduces another sanity check to compensate bogus RIR data. On location02, this affects some networks from APNIC (country code: ZZ) as well as a bunch of smaller allocations within the RIPE region still tagged to CS or YU (Yugoslavia). To my surprise, no network tagged as SU (Soviet Union) was found - while the NIC for .su TLD is still operational. :-) Fixes: #12510 Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org> --- src/python/location-importer.in | 42 ++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/src/python/location-importer.in b/src/python/location-importer.in index 864eab1..89b556a 100644 --- a/src/python/location-importer.in +++ b/src/python/location-importer.in @@ -388,10 +388,17 @@ class CLI(object): TRUNCATE TABLE networks; """) + # Fetch all valid country codes to check parsed networks aganist... + rows = self.db.query("SELECT * FROM countries ORDER BY country_code") + validcountries = [] + + for row in rows: + validcountries.append(row.country_code) + for source in location.importer.WHOIS_SOURCES: with downloader.request(source, return_blocks=True) as f: for block in f: - self._parse_block(block) + self._parse_block(block, validcountries) # Process all parsed networks from every RIR we happen to have access to, # insert the largest network chunks into the networks table immediately... @@ -467,7 +474,7 @@ class CLI(object): # Download data with downloader.request(source) as f: for line in f: - self._parse_line(line) + self._parse_line(line, validcountries) def _check_parsed_network(self, network): """ @@ -532,7 +539,7 @@ class CLI(object): # be suitable for libloc consumption... return True - def _parse_block(self, block): + def _parse_block(self, block, validcountries = None): # Get first line to find out what type of block this is line = block[0] @@ -542,7 +549,7 @@ class CLI(object): # inetnum if line.startswith("inet6num:") or line.startswith("inetnum:"): - return self._parse_inetnum_block(block) + return self._parse_inetnum_block(block, validcountries) # organisation elif line.startswith("organisation:"): @@ -573,7 +580,7 @@ class CLI(object): autnum.get("asn"), autnum.get("org"), ) - def _parse_inetnum_block(self, block): + def _parse_inetnum_block(self, block, validcountries = None): log.debug("Parsing inetnum block:") inetnum = {} @@ -624,17 +631,17 @@ class CLI(object): if not inetnum or not "country" in inetnum: return - # Skip objects with bogus country code 'ZZ' - if inetnum.get("country") == "ZZ": - log.warning("Skipping network with bogus country 'ZZ': %s" % \ - (inetnum.get("inet6num") or inetnum.get("inetnum"))) - return - network = ipaddress.ip_network(inetnum.get("inet6num") or inetnum.get("inetnum"), strict=False) if not self._check_parsed_network(network): return + # Skip objects with unknown country codes + if validcountries and inetnum.get("country") not in validcountries: + log.warning("Skipping network with bogus country '%s': %s" % \ + (inetnum.get("country"), inetnum.get("inet6num") or inetnum.get("inetnum"))) + return + self.db.execute("INSERT INTO _rirdata(network, country) \ VALUES(%s, %s) ON CONFLICT (network) DO UPDATE SET country = excluded.country", "%s" % network, inetnum.get("country"), @@ -659,7 +666,7 @@ class CLI(object): org.get("organisation"), org.get("org-name"), ) - def _parse_line(self, line): + def _parse_line(self, line, validcountries = None): # Skip version line if line.startswith("2"): return @@ -674,8 +681,15 @@ class CLI(object): log.warning("Could not parse line: %s" % line) return - # Skip any lines that are for stats only - if country_code == "*": + # Skip any lines that are for stats only or do not have a country + # code at all (avoids log spam below) + if not country_code or country_code == '*': + return + + # Skip objects with unknown country codes + if validcountries and country_code not in validcountries: + log.warning("Skipping line with bogus country '%s': %s" % \ + (country_code, line)) return if type in ("ipv6", "ipv4"): -- 2.20.1

1 2

2024

2023

2022

2021

2020

2019

2018

2017

Location February 2021