Location March 2023

location@lists.ipfire.org

3 participants
2 discussions

Warning in '__loc_network_tree_count()'
by Gisle Vanem 04 Mar '23

04 Mar '23

Hello list. Compiling with 'clang-cl' on Windows-10, I saw this important warning: network.c(796,10): warning: variable 'counter' set but not used [-Wunused-but-set-variable] size_t* counter = (size_t*)data; ^ So shouldn't the function be: static int __loc_network_tree_count(struct loc_network* network, void* data) { size_t* counter = (size_t*)data; // Increase the counter for each network (*counter)++; return 0; } But I fail to see this ret-val is used for anything. BTW, disasm now is correct: inc qword ptr [rdx] xor eax,eax ret -- --gv

2 3

Re: Upload libloc to Debian
by Stefan Schantl 02 Mar '23

02 Mar '23

Hello Hans-Christoph, a big thanks for writing and sharing your script. I've added it to the official libloc source code by the following commit: ttps://git.ipfire.org/?p=location/libloc.git;a=commit;h=02a7d6ec0bb79f9 62ffe0746d311b3454b11a3db Best regards, -Stefan > > Hey all, > > I just uploaded a new version of the libloc Debian package that > includes bash > completion for the 'location' command. I would like to see this file > included > upstream in your git, so it is also attached to the email. > > If you want to try it, either install location 0.9.16-2 from Debian, > or stick > the attached file in /etc/bash_completion.d/location and open a new > bash shell. > > .hc > > Jochen Sprickerhof: > > Hi Michael, > > > > * Michael Tremer <michael.tremer(a)ipfire.org> [2022-08-16 10:00]: > > > > https://buildd.debian.org/status/package.php?p=libloc > > > > > > I installed a virtual machine with mips64el and the testsuite > > > weirdly runs > > > through. > > > > I was able to reproduce it using ppc64el: > > > > # echo "deb-src http://deb.debian.org/debian unstable main" >> > > /etc/apt/sources.list > > # apt update > > # apt build-dep libloc > > # apt source --compile libloc > > > > Interestingly the new version now also fails on mipsel, so maybe it > > is a flaky > > test? > > > > https://buildd.debian.org/status/logs.php?pkg=libloc&arch=mipsel > > > > Given that it compiled before this means we should try to fix the > > bug as it is > > blocks testing migration, otherwise: > > > > https://tracker.debian.org/pkg/libloc > > > > (The other option would be to request removal of the old mipsel > > version.) > > > > > Additionally, the packages don’t build for Debian any more using > > > my script. > > > > > > I opened a bug ticket with the error here: > > > https://bugzilla.ipfire.org/show_bug.cgi?id=12912 > > > > Looks like you try to cross build (installing crossbuild-essential- > > arm64:amd64), > > maybe that's currently broken. You can try installing qemu-user- > > static and > > replace --host with --arch in debian/build.sh. > > Btw. sbuild updates the chroot before building so there should be > > no need to > > throw it away (for a stable release). > > > > Cheers Jochen > > -- > Signal: +13478504872 > PGP fingerprint: EE66 20C7 136B 0D2C 456C 0A4D E9E2 8DEA 00AA 5556 > https://keys.openpgp.org/search?q=EE6620C7136B0D2C456C0A4DE9E28DEA00AA5556

2 1

2024

2023

2022

2021

2020

2019

2018

2017

Location March 2023