Hi,
On 28 Oct 2020, at 11:50, Gisle Vanem gisle.vanem@gmail.com wrote:
Michael Tremer wrote:
It would be great if we could work on upstreaming your changes for Windows so that they become available for everyone and you no longer need to bundle your own version of libloc without receiving bugfixes from upstream.
Hi again. Sorry for the delay.
That would be tricky for me; I'm a n00b when it comes to Git and pull-requests. But my my Win-sources are under here: https://github.com/gvanem/wsock-trace/tree/master/src/Geo-IP/IPFire/libloc/s...
I would recommend to learn Git then. It is everywhere and that is a skill paying off:
https://wiki.ipfire.org/devel/submit-patches https://wiki.ipfire.org/devel/git
You could perhaps pull them, create a diff and then email me privately to discuss things if you really want Windows support. It would be nice to see Location get a much wider audience (competing with MaxMind and IP2Location ...)
I would like to keep this on the list so that others can join in and help to catch any newly introduced bugs early.
And yes, I would like to see support for Windows, too.
PS. One thing I see now, trying to support Cygwin too; Your calls to 'mmap()' fails on Cygwin32 for a reason I fail to understand; errno = EINVAL. So I use my Win-mmap emulation for Cygwin too. Works fine. Will see about Cygwin64.
It might simply be that mmap() is not supported on Win32. I am not sure if that architecture even needs to be supported by us at all. Is there even one officially supported version of Windows that is still 32 bit?
I would prefer to avoid pulling in a third-party wrapper for mmap() if we can find a different alternative. Those things tend to break really quickly.
Best, -Michael
-- --gv