Hello,
Thank you Valters for the patch :)
On 13 Apr 2021, at 16:38, Peter Müller peter.mueller@ipfire.org wrote:
Hello Valters,
thanks for your patch.
Indeed, the historical changelog of libloc currently contains - um - information in a non-optimal fashion. I guess this was due to the lack of time back then, and nobody of us had good experience with packaging stuff for Debian. Thanks for improving this.
Eventually, we hoped libloc would be used by other distributions as well, since a decent part of the open source community is facing license trouble after MaxMind changed their terms and conditions. I remember Michael having a discussion with some members of the Debian development team, but my memories fail me when it comes to it's results.
You wanted to reach out to them to find out what it takes to get our package into Debian :)
Therefore, I am not sure if libloc is ready in a way we would move from "UNRELEASED" to "unstable". On the one hand, it is used in production for IPFire since a while, on the other hand, nobody else is using the libloc _code_ as such - at least no one I am aware of.
libloc is stable. We should technically give it the 1.0 version tag soon.
However, the Debian package might have some issues, but I do not see that as a reason that we mark it as “please stay away and use something else”. That would send the wrong signal about libloc.
I cannot disclose any other users of libloc apart from those that I have already shared publicly, but we have plenty of downloads of the library so I assume that there are some silent users out there :)
We should work more on making people aware that there now is an alternative to other products available which is truly free software.
-Michael
@Michael: What do you think?
Thanks, and best regards, Peter Müller
Rewriting history is generally considered a "not-so-good" thing, however here the historical data does not align with best practises and therefore it is beneficial to provide a better example going forward.
There is only one initial release. Everything following that should list some kind of release notes or changelog, or at the very least just say something along the lines of "New version" rather than "Initial release".
In this commit, the Git history is used for this task, filtering out "Makefile" changes as to retain only changes that are visible to users, excluding building tooling.
For Debian packages, upon release, the target distribution should be updated to "unstable" (or "experimental" if preferred for any reason) when a release is finalized. During development, an invalid distribution name is expected to be there for tracking unreleased changes. That is why "UNRELEASED" is the standard way of specifying ongoing development, being an invalid distribution name itself.
The "(Closes: #XXXXXX)" tag is intended for linking to Debian bug tracker, such as linking to the initial Intent to Package ticket, or later update/bugfix tickets. There does not appear to be a bug tracker in use for this task here, and the XXXXXX bug ticket number does not take you anywhere. It's therefore better to just remove it.
debian/changelog | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/debian/changelog b/debian/changelog index e0be397..e58c0ca 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,11 +1,18 @@ -libloc (0.9.6-1) UNRELEASED; urgency=medium +libloc (0.9.6-1) unstable; urgency=medium
- Initial release. (Closes: #XXXXXX)
- location-importer.in: skip networks with unknown country codes
- location-importer.in: process unaligned IP ranges in RIR data files
- correctly
- database: Free mmapped countries section
- location-importer.in: reduce log noise for unusable networks
- location-importer.in: delete 6to4 IPv6 space as well
- location-importer.in: fix typo
- location: Fix list-networks-by-as
-- Michael Tremer michael.tremer@ipfire.org Wed, 31 Mar 2021 14:06:00 +0100
-libloc (0.9.5-1) UNRELEASED; urgency=medium +libloc (0.9.5-1) unstable; urgency=medium
- Initial release. (Closes: #XXXXXX)
- Initial release.
-- Stefan Schantl stefan.schantl@ipfire.org Sun, 27 Oct 2019 18:55:44 +0100