What ever happen with the backup / restore icons? Did this get resolved and approved?
Jon
On Mar 23, 2021, at 4:10 AM, Adolf Belka adolf.belka@ipfire.org wrote:
Hi All,
On 22/03/2021 20:58, Jon Murphy wrote:
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes <tom@rymes.net mailto:tom@rymes.net> wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
I never really had a problem with the meaning of the icons. If I forgot I just put the mouse over the icon and it told me what it was.
With text then you need to make sure the text is clear in all languages and then the buttons need to be big enough to hold the complete text. If the buttons are too small then the text becomes too small and that can be a problem for people who have poor eyesight and there are Community members who have to deal with that.
On Mar 22, 2021, at 2:56 PM, Jon Murphy <jcmurphy26@gmail.com mailto:jcmurphy26@gmail.com> wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: |/srv/web/ipfire/html/images/delete.gif| |/srv/web/ipfire/html/images/go-bottom.png| |/srv/web/ipfire/html/images/floppy.gif|
On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
Always good to clean up the code.
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
The benefit of the old system was that the order of the buttons for the backups and addons was the same with addons just having the "Backup" button added to the right.
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
This I think is very important. If you hover the mouse over the Delete button and then accidentally press the button then the file is gone.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>