Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
- For buttons to work, I added two lang strings for button labeling.
- Cleaned up the code a bit, some if-queries were unnessecary (if ($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete" (old: Download was in the middle).
- Marked IPF-files bold => better readability (I already sent this in one day: => https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
-Michael
Best, Matthias <backup-cgi-tuned.png>
Hi,
please note: I added my thoughts below.
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
"Save config"? Important: when using buttons, the text should not be too long. Translation strings for normal-backup/restore and addon-backup/restore *must* differ.
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
I changed this because nearly every page on my IPFire has the 'delete' function - mostly icons - on the far *right* side (e.g.: wio, DNS, dhcp, hosts, wake on lan, etc.) So I thought that placing the 'delete' button in the *middle* made no sense here. Too often, I clicked the wrong icon on the backup page. With text buttons and the changed placement that didn't happen anymore.
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
I won't have much time in the future, but I'll "see what I can get". ;-)
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Not from me - just using it. That's what friends are for... ;-)
Can we make this a function that we can add to various other places, too? Like firewall rules?
Yep. Working here in the following GUIs: aliases, backup, connscheduler, ddns, dhcp, firewall, hosts, media, proxy, qos, routing, urlfilter, wakeonlan, wio and wireless.
Best, Matthias
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
-Michael
Best, Matthias <backup-cgi-tuned.png>
Hi,
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I noticed that... ;-)
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
I went back to *original* IPFire images - for a short overview of the whole process, please take a look at the attachments. Thanks for the tips with 'go-bottom.png'! ;-)
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
As explained in another posting, this came up because other GUI pages use exactly this image order. But by adding tables, I didn't get this to work as I wanted. So I kept to the old order. Still works. ;-)
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Obsolete. If someone wants it, it can be easily added again.
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
At your command... Done. ;-))
Its just the old order: [Download] [Delete] [Backup]
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Implemented.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Sorry - I took a look, but don't know how to do this (the best way). No idea.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
For a laugh: I wrote so much versions in the last days that somewhere in between I didn't know which 'backup.cgi' was which. Sometimes its helpful to choose meaningful file names... ;-)
The attached screenshots show some states of the development process and the most striking changes. Some I could not split into individual patches.
Today I came to the conclusion to send these shots to the list so everyone can take a look. I personally think that (perhaps?) it looks somehow better now. But before going on, I would like to get some feedback.
Thoughts?
Best, Matthias
P.S.: Could "someone" please tell me how we could use the following "sub" ('backup.cgi', Core 155, line 107)!?
... sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv='refresh' content='1;'>" );print "<center><img src='/images/clock.gif' alt='' /><br/><font color='red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::closebox();} ...
Exactly the same sub is used in 'pakfire.cgi' (line 47 and line 207), but I've absolutely no idea how and where (which line in 'backup.cgi'!?) we could implement this sub in 'backup.cgi'. Otherwise its - perhaps - obsolete!?
Matthias - Wow! Lots of work!
I really like the Table format with the new icons!
One picky items: The Logfile should be the same font (size/style) as IPF Files, ISO Files, Addons, and Restore.
One really picky item: Maybe change title from Backup to Backup & Restore.
Very nice! Jon
On Apr 17, 2021, at 2:38 AM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I noticed that... ;-)
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
I went back to *original* IPFire images - for a short overview of the whole process, please take a look at the attachments. Thanks for the tips with 'go-bottom.png'! ;-)
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
As explained in another posting, this came up because other GUI pages use exactly this image order. But by adding tables, I didn't get this to work as I wanted. So I kept to the old order. Still works. ;-)
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Obsolete. If someone wants it, it can be easily added again.
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
At your command... Done. ;-))
Its just the old order: [Download] [Delete] [Backup]
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Implemented.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Sorry - I took a look, but don't know how to do this (the best way). No idea.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
For a laugh: I wrote so much versions in the last days that somewhere in between I didn't know which 'backup.cgi' was which. Sometimes its helpful to choose meaningful file names... ;-)
The attached screenshots show some states of the development process and the most striking changes. Some I could not split into individual patches.
Today I came to the conclusion to send these shots to the list so everyone can take a look. I personally think that (perhaps?) it looks somehow better now. But before going on, I would like to get some feedback.
Thoughts?
Best, Matthias
P.S.: Could "someone" please tell me how we could use the following "sub" ('backup.cgi', Core 155, line 107)!?
... sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv='refresh' content='1;'>" );print "<center><img src='/images/clock.gif' alt='' /><br/><font color='red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::closebox();} ...
Exactly the same sub is used in 'pakfire.cgi' (line 47 and line 207), but I've absolutely no idea how and where (which line in 'backup.cgi'!?) we could implement this sub in 'backup.cgi'. Otherwise its - perhaps - obsolete!? <01_old_style_new_images_changed_order_bold_filenames.png><02_like_01_with_tables.png><03_this_is_onclick.png><04_old_style_buttons_changed_order.png><05_testing_buttons_and_tables.png>
Hi,
On 17.04.2021 21:42, Jon Murphy wrote:
Matthias - Wow! Lots of work!
I really like the Table format with the new icons!
One picky items: The Logfile should be the same font (size/style) as IPF Files, ISO Files, Addons, and Restore.
One really picky item: Maybe change title from Backup to Backup & Restore.
Thanks, Jon. ;-)
Attached: screenshot of the last version... ;-)
Best, Matthias
Very nice! Jon
On Apr 17, 2021, at 2:38 AM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi,
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I noticed that... ;-)
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
I went back to *original* IPFire images - for a short overview of the whole process, please take a look at the attachments. Thanks for the tips with 'go-bottom.png'! ;-)
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
As explained in another posting, this came up because other GUI pages use exactly this image order. But by adding tables, I didn't get this to work as I wanted. So I kept to the old order. Still works. ;-)
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Obsolete. If someone wants it, it can be easily added again.
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
At your command... Done. ;-))
Its just the old order: [Download] [Delete] [Backup]
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Implemented.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Sorry - I took a look, but don't know how to do this (the best way). No idea.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
For a laugh: I wrote so much versions in the last days that somewhere in between I didn't know which 'backup.cgi' was which. Sometimes its helpful to choose meaningful file names... ;-)
The attached screenshots show some states of the development process and the most striking changes. Some I could not split into individual patches.
Today I came to the conclusion to send these shots to the list so everyone can take a look. I personally think that (perhaps?) it looks somehow better now. But before going on, I would like to get some feedback.
Thoughts?
Best, Matthias
P.S.: Could "someone" please tell me how we could use the following "sub" ('backup.cgi', Core 155, line 107)!?
... sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv='refresh' content='1;'>" );print "<center><img src='/images/clock.gif' alt='' /><br/><font color='red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::closebox();} ...
Exactly the same sub is used in 'pakfire.cgi' (line 47 and line 207), but I've absolutely no idea how and where (which line in 'backup.cgi'!?) we could implement this sub in 'backup.cgi'. Otherwise its - perhaps - obsolete!? <01_old_style_new_images_changed_order_bold_filenames.png><02_like_01_with_tables.png><03_this_is_onclick.png><04_old_style_buttons_changed_order.png><05_testing_buttons_and_tables.png>
Hi Matthias,
I like the 02_like_01-with_tables.png version
The table layout works very well.
The dustbin icon for the delete also is very clear.
Regards,
Adolf.
Sent from my Desktop Computer
On 17/04/2021 09:38, Matthias Fischer wrote:
Hi,
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I noticed that... ;-)
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
I went back to *original* IPFire images - for a short overview of the whole process, please take a look at the attachments. Thanks for the tips with 'go-bottom.png'! ;-)
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
As explained in another posting, this came up because other GUI pages use exactly this image order. But by adding tables, I didn't get this to work as I wanted. So I kept to the old order. Still works. ;-)
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Obsolete. If someone wants it, it can be easily added again.
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
At your command... Done. ;-))
Its just the old order: [Download] [Delete] [Backup]
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Implemented.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Sorry - I took a look, but don't know how to do this (the best way). No idea.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
For a laugh: I wrote so much versions in the last days that somewhere in between I didn't know which 'backup.cgi' was which. Sometimes its helpful to choose meaningful file names... ;-)
The attached screenshots show some states of the development process and the most striking changes. Some I could not split into individual patches.
Today I came to the conclusion to send these shots to the list so everyone can take a look. I personally think that (perhaps?) it looks somehow better now. But before going on, I would like to get some feedback.
Thoughts?
Best, Matthias
P.S.: Could "someone" please tell me how we could use the following "sub" ('backup.cgi', Core 155, line 107)!?
... sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv='refresh' content='1;'>" );print "<center><img src='/images/clock.gif' alt='' /><br/><font color='red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::closebox();} ...
Exactly the same sub is used in 'pakfire.cgi' (line 47 and line 207), but I've absolutely no idea how and where (which line in 'backup.cgi'!?) we could implement this sub in 'backup.cgi'. Otherwise its - perhaps - obsolete!?
On 18.04.2021 15:54, Adolf Belka wrote:
Hi Matthias,
I like the 02_like_01-with_tables.png version
Yep. That's my favorite, too. "Buttons and tables" weren't so nice at all.
The last version (backup.cgi.23.png) from today looks even better. IMHO.
Please see my posting from today (11:17 o'clock).
The table layout works very well.
Thanks. Sometimes is was bit fiddly. I can only test on 19". I'm not really sure how it looks on bigger monitors...
The dustbin icon for the delete also is very clear.
These are all original icons from IPFire.
I there are no further wishes or improvements I would push this in the next days.
Best, Matthias
Regards,
Adolf.
Sent from my Desktop Computer
On 17/04/2021 09:38, Matthias Fischer wrote:
Hi,
On 22.03.2021 12:36, Michael Tremer wrote:
Hello,
On 21 Mar 2021, at 18:25, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
Very good idea. This page is quite essential, but the design is quite complicated and difficult to use.
I noticed that... ;-)
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
- Changed icons to buttons => better readability.
I went back to *original* IPFire images - for a short overview of the whole process, please take a look at the attachments. Thanks for the tips with 'go-bottom.png'! ;-)
Yes. I am not sure whether “Backup” is a good choice, because it could be interpreted as a noun. Maybe “Backup Now” or “Update Backup” would be a better choice. Does anybody have any ideas?
- For buttons to work, I added two lang strings for button labeling.
No problem here.
- Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
What is the rationale here?
Why is this order better?
As explained in another posting, this came up because other GUI pages use exactly this image order. But by adding tables, I didn't get this to work as I wanted. So I kept to the old order. Still works. ;-)
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
Obsolete. If someone wants it, it can be easily added again.
Can we not have a proper table here? Like this:
| Package | Last Backup | Size | | | wio | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |
At your command... Done. ;-))
Its just the old order: [Download] [Delete] [Backup]
- Added query for deleting a backup file (onclick="return confirm...).
Very good idea, too.
Implemented.
Can we make this a function that we can add to various other places, too? Like firewall rules?
Sorry - I took a look, but don't know how to do this (the best way). No idea.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Yes.
Thoughts? Opinions?
Very good ideas. Please keep them all in individual patches so that they can be reviewed one by one :)
For a laugh: I wrote so much versions in the last days that somewhere in between I didn't know which 'backup.cgi' was which. Sometimes its helpful to choose meaningful file names... ;-)
The attached screenshots show some states of the development process and the most striking changes. Some I could not split into individual patches.
Today I came to the conclusion to send these shots to the list so everyone can take a look. I personally think that (perhaps?) it looks somehow better now. But before going on, I would like to get some feedback.
Thoughts?
Best, Matthias
P.S.: Could "someone" please tell me how we could use the following "sub" ('backup.cgi', Core 155, line 107)!?
... sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv='refresh' content='1;'>" );print "<center><img src='/images/clock.gif' alt='' /><br/><font color='red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::closebox();} ...
Exactly the same sub is used in 'pakfire.cgi' (line 47 and line 207), but I've absolutely no idea how and where (which line in 'backup.cgi'!?) we could implement this sub in 'backup.cgi'. Otherwise its - perhaps - obsolete!?
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: /srv/web/ipfire/html/images/delete.gif /srv/web/ipfire/html/images/go-bottom.png /srv/web/ipfire/html/images/floppy.gif
On Mar 21, 2021, at 1:25 PM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
On Mar 22, 2021, at 2:56 PM, Jon Murphy jcmurphy26@gmail.com wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: /srv/web/ipfire/html/images/delete.gif /srv/web/ipfire/html/images/go-bottom.png /srv/web/ipfire/html/images/floppy.gif
On Mar 21, 2021, at 1:25 PM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes tom@rymes.net wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
On Mar 22, 2021, at 2:56 PM, Jon Murphy jcmurphy26@gmail.com wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: /srv/web/ipfire/html/images/delete.gif /srv/web/ipfire/html/images/go-bottom.png /srv/web/ipfire/html/images/floppy.gif
On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
Hi All,
On 22/03/2021 20:58, Jon Murphy wrote:
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes <tom@rymes.net mailto:tom@rymes.net> wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
I never really had a problem with the meaning of the icons. If I forgot I just put the mouse over the icon and it told me what it was.
With text then you need to make sure the text is clear in all languages and then the buttons need to be big enough to hold the complete text. If the buttons are too small then the text becomes too small and that can be a problem for people who have poor eyesight and there are Community members who have to deal with that.
On Mar 22, 2021, at 2:56 PM, Jon Murphy <jcmurphy26@gmail.com mailto:jcmurphy26@gmail.com> wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: |/srv/web/ipfire/html/images/delete.gif| |/srv/web/ipfire/html/images/go-bottom.png| |/srv/web/ipfire/html/images/floppy.gif|
On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
Always good to clean up the code.
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
The benefit of the old system was that the order of the buttons for the backups and addons was the same with addons just having the "Backup" button added to the right.
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
This I think is very important. If you hover the mouse over the Delete button and then accidentally press the button then the file is gone.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
What ever happen with the backup / restore icons? Did this get resolved and approved?
Jon
On Mar 23, 2021, at 4:10 AM, Adolf Belka adolf.belka@ipfire.org wrote:
Hi All,
On 22/03/2021 20:58, Jon Murphy wrote:
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes <tom@rymes.net mailto:tom@rymes.net> wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
I never really had a problem with the meaning of the icons. If I forgot I just put the mouse over the icon and it told me what it was.
With text then you need to make sure the text is clear in all languages and then the buttons need to be big enough to hold the complete text. If the buttons are too small then the text becomes too small and that can be a problem for people who have poor eyesight and there are Community members who have to deal with that.
On Mar 22, 2021, at 2:56 PM, Jon Murphy <jcmurphy26@gmail.com mailto:jcmurphy26@gmail.com> wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: |/srv/web/ipfire/html/images/delete.gif| |/srv/web/ipfire/html/images/go-bottom.png| |/srv/web/ipfire/html/images/floppy.gif|
On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
Always good to clean up the code.
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
The benefit of the old system was that the order of the buttons for the backups and addons was the same with addons just having the "Backup" button added to the right.
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
This I think is very important. If you hover the mouse over the Delete button and then accidentally press the button then the file is gone.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
Hi, On 14.04.2021 22:48, Jon Murphy wrote:
What ever happen with the backup / restore icons? Did this get resolved and approved?
I'm working on this in my spare time. E.g.: icons, 'onclick' and tables (as Michael mentioned in another posting)
Sadly, I've not much time left these days...
But I'm at it.
Best, Matthias
Jon
On Mar 23, 2021, at 4:10 AM, Adolf Belka adolf.belka@ipfire.org wrote:
Hi All,
On 22/03/2021 20:58, Jon Murphy wrote:
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes <tom@rymes.net mailto:tom@rymes.net> wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
I never really had a problem with the meaning of the icons. If I forgot I just put the mouse over the icon and it told me what it was.
With text then you need to make sure the text is clear in all languages and then the buttons need to be big enough to hold the complete text. If the buttons are too small then the text becomes too small and that can be a problem for people who have poor eyesight and there are Community members who have to deal with that.
On Mar 22, 2021, at 2:56 PM, Jon Murphy <jcmurphy26@gmail.com mailto:jcmurphy26@gmail.com> wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: |/srv/web/ipfire/html/images/delete.gif| |/srv/web/ipfire/html/images/go-bottom.png| |/srv/web/ipfire/html/images/floppy.gif|
On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote:
Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588
Hi,
in the meantime I worked on this - a bit.
I've made several changes and adjustments which could be implemented one by one - if they are wanted/accepted:
Changed icons to buttons => better readability.
For buttons to work, I added two lang strings for button labeling.
Cleaned up the code a bit, some if-queries were unnessecary (if
($cgiparams{'ACTION'} eq...).
Always good to clean up the code.
- Changed the order of the (Addon-)buttons to "Download - Save - Delete"
(old: Download was in the middle).
The benefit of the old system was that the order of the buttons for the backups and addons was the same with addons just having the "Backup" button added to the right.
- Marked IPF-files bold => better readability (I already sent this in
one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/).
- Added query for deleting a backup file (onclick="return confirm...).
This I think is very important. If you hover the mouse over the Delete button and then accidentally press the button then the file is gone.
Details in the attached screenshot.
Proposed ToDo - as a start: Alter the info text for restoring to make clear that only the addon *configs* are restored, not the addons themselves.
Thoughts? Opinions?
Best, Matthias <backup-cgi-tuned.png>
Ahh! Got it! Thank you!
On Apr 15, 2021, at 3:58 AM, Matthias Fischer matthias.fischer@ipfire.org wrote:
Hi, On 14.04.2021 22:48, Jon Murphy wrote:
What ever happen with the backup / restore icons? Did this get resolved and approved?
I'm working on this in my spare time. E.g.: icons, 'onclick' and tables (as Michael mentioned in another posting)
Sadly, I've not much time left these days...
But I'm at it.
Best, Matthias
Jon
On Mar 23, 2021, at 4:10 AM, Adolf Belka adolf.belka@ipfire.org wrote:
Hi All,
On 22/03/2021 20:58, Jon Murphy wrote:
The current icons are very confusing! Bigger and less confusing icons would be great!
On Mar 22, 2021, at 2:51 PM, Tom Rymes <tom@rymes.net mailto:tom@rymes.net> wrote:
On the flip side, I have always found the icons to be confusing. Which is delete, which is download? Hovering if the mouse, etc ensues. If they were bigger it might be less confusing, but words are always clear.
I never really had a problem with the meaning of the icons. If I forgot I just put the mouse over the icon and it told me what it was.
With text then you need to make sure the text is clear in all languages and then the buttons need to be big enough to hold the complete text. If the buttons are too small then the text becomes too small and that can be a problem for people who have poor eyesight and there are Community members who have to deal with that.
On Mar 22, 2021, at 2:56 PM, Jon Murphy <jcmurphy26@gmail.com mailto:jcmurphy26@gmail.com> wrote:
For what it is worth, I’d rather see icons and not the buttons. It is a much cleaner look. Just my opinion.
The icons already available on the IPFire box look better to me: |/srv/web/ipfire/html/images/delete.gif| |/srv/web/ipfire/html/images/go-bottom.png| |/srv/web/ipfire/html/images/floppy.gif|
> On Mar 21, 2021, at 1:25 PM, Matthias Fischer <matthias.fischer@ipfire.org mailto:matthias.fischer@ipfire.org> wrote: > > Based on https://bugzilla.ipfire.org/show_bug.cgi?id=12588 https://bugzilla.ipfire.org/show_bug.cgi?id=12588 > > Hi, > > in the meantime I worked on this - a bit. > > I've made several changes and adjustments which could be implemented one > by one - if they are wanted/accepted: > > - Changed icons to buttons => better readability. > > - For buttons to work, I added two lang strings for button labeling. > > - Cleaned up the code a bit, some if-queries were unnessecary (if > ($cgiparams{'ACTION'} eq...). >
Always good to clean up the code.
> - Changed the order of the (Addon-)buttons to "Download - Save - Delete" > (old: Download was in the middle). >
The benefit of the old system was that the order of the buttons for the backups and addons was the same with addons just having the "Backup" button added to the right.
> - Marked IPF-files bold => better readability (I already sent this in > one day: => https://patchwork.ipfire.org/patch/3124/ https://patchwork.ipfire.org/patch/3124/). > > - Added query for deleting a backup file (onclick="return confirm...). >
This I think is very important. If you hover the mouse over the Delete button and then accidentally press the button then the file is gone.
> Details in the attached screenshot. > > Proposed ToDo - as a start: Alter the info text for restoring to make > clear that only the addon *configs* are restored, not the addons themselves. > > Thoughts? Opinions? > > Best, > Matthias > <backup-cgi-tuned.png>
-
Adolf Belka -
Jon Murphy -
Matthias Fischer -
Michael Tremer -
Tom Rymes