Hello,
thanks for taking this opportunity this quickly.
On Sat, 2015-10-17 at 08:44 +0200, Blago Culjak wrote:
Hello, Michael, I have taken-over bug, https://bugzilla.ipfire.org/show_bug.cgi?id=10918, made changed, now bug is gone on my test system.
How should I send it to you guys for merge?
Please follow this guide: http://wiki.ipfire.org/devel/submit-patches
Feel free to ask questions if anything is not clear.
I have changed 54 line of /srv/web/ipfire/html/themes/ipfire/include/js/refreshInetInfo.js and it works fine, in kbits/mbits...
There are also other themes, did you check these as well? There is also a short moment after a page is loaded when the JS is not executed, yet. I am just wondering if it says "kBit" there as well.
Thank you for helping out a new guy.
-Michael
P.S. Please make sure to reply to the list as well.
Subject: [ANNOUNCE] Good First Bugs From: michael.tremer@ipfire.org To: development@lists.ipfire.org Date: Fri, 16 Oct 2015 22:08:21 +0100
Hello,
as discussed at the IPFire Developer Summit 2015, we are now introducing "Good First Bugs". These are bugs tagged with the
keyword
"GoodFirstBug" and recommended for beginners to solve.
They should help us to encourage more people to start development
with
IPFire and are tasks that should be resolvable in a reasonable
amount
of time. They usually should not require knowledge in any advanced programming languages.
http://wiki.ipfire.org/devel/bugzilla/good-first-bug
These bugs can be found by searching for the keyword on Bugzilla:
https://bugzilla.ipfire.org/buglist.cgi?keywords=GoodFirstBug
This message is to all the developers who should tag appropriate
bugs
as such, encourage people to take on a bug and mentor them if any
help
is needed.
There will also be a post on the IPFire planet release some time
next
week to announce this to the people who are following our blog and other social media.
http://planet.ipfire.org/post/good-first-bugs
Best, -Michael
Hello, Michael, did read everything, it seems that I still can't get hang of some thing. I will firstly try just to patch this bug, then try to patch for other themes and JS load execute time.
It seems hard for me to get it in format that you guys use and if some one has some template of e-mail i should use or commands you use to get that diff output, I would be grateful.
So for, I'm stuck here, still not getting output as you guys, and I know how cranky you are about submit format. :) [PATCH] package: Typo in Traffic Meter
This solves bug 10918 Signed-off-by: Blago Culjak blago.culjak@hotmail.com
------------ html/html/themes/ipfire/include/js/refreshInetInfo.js ------------ index 259f86e..7d9cf8f 100644 @@ -51,7 +51,7 @@ function refreshInetInfo() { }
function format_bytes(bytes) { - var units = ["Bit/s", "kBit/s", "MBit/s", "GBit/s", "TBit/s"]; + var units = ["bit/s", "kbit/s", "Mbit/s", "Gbit/s", "Tbit/s"];
var unit = units[0]; for (var i = 1; i < units.length; i++) {
Subject: Bug #10918 was: [ANNOUNCE] Good First Bugs From: michael.tremer@ipfire.org To: blago.culjak@hotmail.com; development@lists.ipfire.org Date: Sat, 17 Oct 2015 12:51:36 +0100
Hello,
thanks for taking this opportunity this quickly.
On Sat, 2015-10-17 at 08:44 +0200, Blago Culjak wrote:
Hello, Michael, I have taken-over bug, https://bugzilla.ipfire.org/show_bug.cgi?id=10918, made changed, now bug is gone on my test system.
How should I send it to you guys for merge?
Please follow this guide: http://wiki.ipfire.org/devel/submit-patches
Feel free to ask questions if anything is not clear.
I have changed 54 line of /srv/web/ipfire/html/themes/ipfire/include/js/refreshInetInfo.js and it works fine, in kbits/mbits...
There are also other themes, did you check these as well? There is also a short moment after a page is loaded when the JS is not executed, yet. I am just wondering if it says "kBit" there as well.
Thank you for helping out a new guy.
-Michael
P.S. Please make sure to reply to the list as well.
Subject: [ANNOUNCE] Good First Bugs From: michael.tremer@ipfire.org To: development@lists.ipfire.org Date: Fri, 16 Oct 2015 22:08:21 +0100
Hello,
as discussed at the IPFire Developer Summit 2015, we are now introducing "Good First Bugs". These are bugs tagged with the
keyword
"GoodFirstBug" and recommended for beginners to solve.
They should help us to encourage more people to start development
with
IPFire and are tasks that should be resolvable in a reasonable
amount
of time. They usually should not require knowledge in any advanced programming languages.
http://wiki.ipfire.org/devel/bugzilla/good-first-bug
These bugs can be found by searching for the keyword on Bugzilla:
https://bugzilla.ipfire.org/buglist.cgi?keywords=GoodFirstBug
This message is to all the developers who should tag appropriate
bugs
as such, encourage people to take on a bug and mentor them if any
help
is needed.
There will also be a post on the IPFire planet release some time
next
week to announce this to the people who are following our blog and other social media.
http://planet.ipfire.org/post/good-first-bugs
Best, -Michael
On Mon, 19 Oct 2015 12:24:36 +0200, Blago Culjak blago.culjak@hotmail.com wrote:
It seems hard for me to get it in format that you guys use and if some one has some template of e-mail i should use or commands you use to get that diff output, I would be grateful.
Are you on Windows or Linux? I could send you the notes I use for Windows with Tortoisegit this evening (newbie myself).
[PATCH] package: Typo in Traffic Meter
This solves bug 10918 Signed-off-by: Blago Culjak blago.culjak@hotmail.com
I suppose the first line would be your subject of the mail.
Then you are missing an explanatory line what this patch does and why this is necessary. More detail can optionally be specified after a blank line (this also includes "This solves...") "Signed-off-by" should be separated by another blank line.
Make sure to use text-format instead of HTML for your mail. Don't use line-wrapping --> What mail program do you use?
Lars
Hi,
It seems hard for me to get it in format that you guys use and if some one has some template of e-mail i should use or commands you use to get that diff output, I would be grateful.
Are you on Windows or Linux? I could send you the notes I use for Windows with Tortoisegit this evening (newbie myself).
I use Windows.
[PATCH] package: Typo in Traffic Meter
This solves bug 10918 Signed-off-by: Blago Culjak blago.culjak@hotmail.com
I suppose the first line would be your subject of the mail.
Then you are missing an explanatory line what this patch does and why this is necessary. More detail can optionally be specified after a blank line (this also includes "This solves...") "Signed-off-by" should be separated by another blank line.
Sure, will do that in future.
Make sure to use text-format instead of HTML for your mail. Don't use line-wrapping --> What mail program do you use?
I use web based live.com, but it can use text-format, don't worry.
If you could send me those notes, or even update it on wiki, it would be great benefit.
Lars
On Mon, 19 Oct 2015 13:05:36 +0200, Blago Culjak blago.culjak@hotmail.com wrote:
Make sure to use text-format instead of HTML for your mail. Don't use line-wrapping --> What mail program do you use?
I use web based live.com, but it can use text-format, don't worry.
Are you sure that this also implies that line-wrapping is disabled?
If you could send me those notes, or even update it on wiki, it would be great benefit.
Yes sure, will send you some text this evening (CEST). afaik, everything is already in the wiki. it's just some kind of cheat-sheet.
Lars
If you could send me those notes, or even update it on wiki, it would be great benefit.
Here you go:
== Send in a patch == * Thunderbird > Compose new mail * Options > Enable Word Wrap: disable * Recipient: development@lists.ipfire.org development@lists.ipfire.org * Subject: [PATCH] <text> * Body: First line contains a short description of the patch.
After a blank line, a more precise description follows (if needed; you can leave that out for smaller patches). Optionally together with a "Fixes bug <number>" in case the patch fixes a bug
Signed-off-by: Your Name your@email.adress ---
* After the "---" and blank line you put the patch as plain text * Having sent the mail to the list, you can check http://patchwork.ipfire.org/project/ipfire/list * In case there is a corresponding bug in the bugtracker, you should add a note there with the URL to the patch
-
Blago Culjak -
Larsen -
Michael Tremer