Hello,

On 21 Nov 2022, at 13:57, Peter Müller peter.mueller@ipfire.org wrote:

Hello *,

while trying to update libloc in IPFire 2.x, I noticed a possible quirk in the way the Perl module and man page files are currently installed. The rootfile diff looks as follows:

diff --git a/config/rootfiles/common/libloc b/config/rootfiles/common/libloc index 7eb94217e..628ac343f 100644 --- a/config/rootfiles/common/libloc +++ b/config/rootfiles/common/libloc @@ -1,3 +1,8 @@ +#Location.3 +Location.pm +#auto +#auto/Location +auto/Location/Location.so

This is very much incorrect and was probably introduced here:

https://git.ipfire.org/?p=location/libloc.git;a=commitdiff;h=b26c2109eaf229d...

What did the configure script print at the end for the perl directories? It looks like the paths are not correctly detected.

#etc/cron.daily #etc/cron.daily/location-update usr/bin/location @@ -22,10 +27,6 @@ usr/bin/location #usr/lib/libloc.so usr/lib/libloc.so.1 usr/lib/libloc.so.1.0.2 -usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/Location.pm -#usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Location -#usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Location/.packlist -usr/lib/perl5/site_perl/5.36.0/xxxMACHINExxx-linux-thread-multi/auto/Location/Location.so #usr/lib/pkgconfig/libloc.pc #usr/lib/python3.10/site-packages/_location.la usr/lib/python3.10/site-packages/_location.so @@ -38,7 +39,6 @@ usr/lib/python3.10/site-packages/location/i18n.py #usr/lib/python3.10/site-packages/location/importer.py usr/lib/python3.10/site-packages/location/logger.py #usr/share/locale/de/LC_MESSAGES/libloc.mo -#usr/share/man/man3/Location.3 #var/lib/location var/lib/location/database.db var/lib/location/ipset

It appears that, despite ./configure called with parameters such as "--disable-man-pages", libloc always installs a man page, and now places Perl files in the current working directory rather than something like /usr/lib/perl5/site_perl/5.36.0/...

Does the ./configure call need additional parameters? Is this behaviour intended?

—-disable-man-pages is working okay as our own man pages are not installed.

The man page that is being installed is from the Perl module.

Potentially, we will need to pass this to the perl build scripts. I wouldn’t consider this a very high priority, so please open a bug and assign it to Stefan.

-Michael

Thanks, and best regards, Peter Müller